cmd: remove superfluous if in eficonfig_edit_boot_option
authorHeinrich Schuchardt <heinrich.schuchardt@canonical.com>
Thu, 10 Nov 2022 11:19:30 +0000 (12:19 +0100)
committerHeinrich Schuchardt <heinrich.schuchardt@canonical.com>
Wed, 16 Nov 2022 07:34:06 +0000 (08:34 +0100)
Goto for an immediately succeeding label is superfluous.

Fixes: 87d791423ac6 ("eficonfig: menu-driven addition of UEFI boot option")
Addresses-Coverity: 376202 ("Identical code for different branches")
Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
Reviewed-by: Ilias Apalodimas <ilias.apalodimas@linaro.org>
cmd/eficonfig.c

index 2595dd9..0dc6e7b 100644 (file)
@@ -1527,8 +1527,6 @@ static efi_status_t eficonfig_edit_boot_option(u16 *varname, struct eficonfig_bo
        }
 
        ret = eficonfig_set_boot_option(varname, final_dp, final_dp_size, bo->description, tmp);
-       if (ret != EFI_SUCCESS)
-               goto out;
 out:
        free(tmp);
        free(bo->optional_data);