hpsa: report allocation failures while allocating SG chain blocks
authorRobert Elliott <elliott@hp.com>
Fri, 23 Jan 2015 22:42:42 +0000 (16:42 -0600)
committerJames Bottomley <JBottomley@Parallels.com>
Mon, 2 Feb 2015 17:57:39 +0000 (09:57 -0800)
Reviewed-by: Scott Teel <scott.teel@pmcs.com>
Signed-off-by: Robert Elliott <elliott@hp.com>
Signed-off-by: Don Brace <don.brace@pmcs.com>
Signed-off-by: Christoph Hellwig <hch@lst.de>
drivers/scsi/hpsa.c

index 64d17d1..dc328ce 100644 (file)
@@ -1480,13 +1480,17 @@ static int hpsa_allocate_sg_chain_blocks(struct ctlr_info *h)
 
        h->cmd_sg_list = kzalloc(sizeof(*h->cmd_sg_list) * h->nr_cmds,
                                GFP_KERNEL);
-       if (!h->cmd_sg_list)
+       if (!h->cmd_sg_list) {
+               dev_err(&h->pdev->dev, "Failed to allocate SG list\n");
                return -ENOMEM;
+       }
        for (i = 0; i < h->nr_cmds; i++) {
                h->cmd_sg_list[i] = kmalloc(sizeof(*h->cmd_sg_list[i]) *
                                                h->chainsize, GFP_KERNEL);
-               if (!h->cmd_sg_list[i])
+               if (!h->cmd_sg_list[i]) {
+                       dev_err(&h->pdev->dev, "Failed to allocate cmd SG\n");
                        goto clean;
+               }
        }
        return 0;