scsi: ufs: print helpful hint when response size exceed buffer size
authorBean Huo <beanhuo@micron.com>
Tue, 12 Nov 2019 22:34:35 +0000 (23:34 +0100)
committerMartin K. Petersen <martin.petersen@oracle.com>
Wed, 13 Nov 2019 03:21:34 +0000 (22:21 -0500)
Print out returned response size and buffer size, while the front one is
bigger than the back one.

Link: https://lore.kernel.org/r/20191112223436.27449-2-huobean@gmail.com
Reviewed-by: Alim Akhtar <alim.akhtar@samsung.com>
Reviewed-by: Bart Van Assche <bvanassche@acm.org>
Signed-off-by: Bean Huo <beanhuo@micron.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/ufs/ufshcd.c

index 9cbe3b4..527bd3b 100644 (file)
@@ -1938,8 +1938,8 @@ int ufshcd_copy_query_response(struct ufs_hba *hba, struct ufshcd_lrb *lrbp)
                        memcpy(hba->dev_cmd.query.descriptor, descp, resp_len);
                } else {
                        dev_warn(hba->dev,
-                               "%s: Response size is bigger than buffer",
-                               __func__);
+                                "%s: rsp size %d is bigger than buffer size %d",
+                                __func__, resp_len, buf_len);
                        return -EINVAL;
                }
        }
@@ -5864,7 +5864,9 @@ static int ufshcd_issue_devman_upiu_cmd(struct ufs_hba *hba,
                        memcpy(desc_buff, descp, resp_len);
                        *buff_len = resp_len;
                } else {
-                       dev_warn(hba->dev, "rsp size is bigger than buffer");
+                       dev_warn(hba->dev,
+                                "%s: rsp size %d is bigger than buffer size %d",
+                                __func__, resp_len, *buff_len);
                        *buff_len = 0;
                        err = -EINVAL;
                }