irqchip/apple-aic: Fix refcount leak in aic_of_ic_init
authorMiaoqian Lin <linmq006@gmail.com>
Wed, 1 Jun 2022 08:09:27 +0000 (12:09 +0400)
committerMarc Zyngier <maz@kernel.org>
Thu, 9 Jun 2022 16:36:57 +0000 (17:36 +0100)
of_get_child_by_name() returns a node pointer with refcount
incremented, we should use of_node_put() on it when not need anymore.
Add missing of_node_put() to avoid refcount leak.

Fixes: a5e8801202b3 ("irqchip/apple-aic: Parse FIQ affinities from device-tree")
Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
Signed-off-by: Marc Zyngier <maz@kernel.org>
Link: https://lore.kernel.org/r/20220601080930.31005-4-linmq006@gmail.com
drivers/irqchip/irq-apple-aic.c

index 478d0af..5ac8318 100644 (file)
@@ -1144,6 +1144,7 @@ static int __init aic_of_ic_init(struct device_node *node, struct device_node *p
                for_each_child_of_node(affs, chld)
                        build_fiq_affinity(irqc, chld);
        }
+       of_node_put(affs);
 
        set_handle_irq(aic_handle_irq);
        set_handle_fiq(aic_handle_fiq);