projects
/
platform
/
kernel
/
linux-3.10.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
7d800b1
)
upstream: [media] gpsca: remove the risk of a division by zero
author
Mauro Carvalho Chehab
<m.chehab@samsung.com>
Mon, 7 Apr 2014 13:52:43 +0000
(10:52 -0300)
committer
Chanho Park
<chanho61.park@samsung.com>
Tue, 18 Nov 2014 02:55:09 +0000
(11:55 +0900)
As reported by Coverity, there's a potential risk of a division
by zero on some calls to jpeg_set_qual(), if quality is zero.
As quality can't be 0 or lower than that, adds an extra clause
to cover this special case.
Coverity reports: CID#
11922280
, CID#
11922293
, CID#
11922295
Signed-off-by: Mauro Carvalho Chehab <m.chehab@samsung.com>
drivers/media/usb/gspca/jpeg.h
patch
|
blob
|
history
diff --git
a/drivers/media/usb/gspca/jpeg.h
b/drivers/media/usb/gspca/jpeg.h
index
ab54910
..
0aa2b67
100644
(file)
--- a/
drivers/media/usb/gspca/jpeg.h
+++ b/
drivers/media/usb/gspca/jpeg.h
@@
-154,7
+154,9
@@
static void jpeg_set_qual(u8 *jpeg_hdr,
{
int i, sc;
- if (quality < 50)
+ if (quality <= 0)
+ sc = 5000;
+ else if (quality < 50)
sc = 5000 / quality;
else
sc = 200 - quality * 2;