Add shaderSubgroupExtendedTypes to mandatory features
authorGraeme Leese <gleese@broadcom.com>
Tue, 24 Mar 2020 15:36:37 +0000 (15:36 +0000)
committerAlexander Galazin <Alexander.Galazin@arm.com>
Thu, 2 Apr 2020 08:13:38 +0000 (04:13 -0400)
This was supposed to be mandatory in Vulkan 1.2 but it was not
documented in the spec.

Change-Id: Idd494770f7b7f454356b25ca2697cbba1c20c2bf
Components: Vulkan
Affects: dEQP-VK.info.device_mandatory_features

external/vulkancts/framework/vulkan/vkMandatoryFeatures.inl
external/vulkancts/scripts/src/mandatory_features.txt

index b2ac3f2..4ba806f 100644 (file)
@@ -401,6 +401,15 @@ bool checkMandatoryFeatures(const vkt::Context& context)
 
        if ( context.contextSupports(vk::ApiVersion(1, 2, 0)) )
        {
+               if ( physicalDeviceVulkan12Features.shaderSubgroupExtendedTypes == VK_FALSE )
+               {
+                       log << tcu::TestLog::Message << "Mandatory feature shaderSubgroupExtendedTypes not supported" << tcu::TestLog::EndMessage;
+                       result = false;
+               }
+       }
+
+       if ( context.contextSupports(vk::ApiVersion(1, 2, 0)) )
+       {
                if ( physicalDeviceVulkan12Features.imagelessFramebuffer == VK_FALSE )
                {
                        log << tcu::TestLog::Message << "Mandatory feature imagelessFramebuffer not supported" << tcu::TestLog::EndMessage;
index 643dd0b..cdbae99 100644 (file)
@@ -35,6 +35,7 @@ VkPhysicalDevicePipelineExecutablePropertiesFeaturesKHR       pipelineExecutableInfo
 VkPhysicalDeviceSubgroupSizeControlFeaturesEXT                 subgroupSizeControl                                                                     REQUIREMENTS ( VK_EXT_subgroup_size_control )
 VkPhysicalDeviceSubgroupSizeControlFeaturesEXT                 computeFullSubgroups                                                            REQUIREMENTS ( VK_EXT_subgroup_size_control )
 VkPhysicalDeviceVulkan12Features                                               subgroupBroadcastDynamicId                                                      REQUIREMENTS ( "ApiVersion(1, 2, 0)" )
+VkPhysicalDeviceVulkan12Features                                               shaderSubgroupExtendedTypes                                                     REQUIREMENTS ( "ApiVersion(1, 2, 0)" )
 VkPhysicalDeviceVulkan12Features                                               imagelessFramebuffer                                                            REQUIREMENTS ( "ApiVersion(1, 2, 0)" )
 VkPhysicalDeviceVulkan12Features                                               uniformBufferStandardLayout                                                     REQUIREMENTS ( "ApiVersion(1, 2, 0)" )
 VkPhysicalDeviceVulkan12Features                                               separateDepthStencilLayouts                                                     REQUIREMENTS ( "ApiVersion(1, 2, 0)" )