iio: light: lm3533-als: Use devm_iio_device_alloc
authorSachin Kamat <sachin.kamat@linaro.org>
Tue, 30 Jul 2013 08:44:00 +0000 (09:44 +0100)
committerJonathan Cameron <jic23@kernel.org>
Sat, 3 Aug 2013 17:55:25 +0000 (18:55 +0100)
Using devm_iio_device_alloc makes code simpler.

Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
Cc: Johan Hovold <jhovold@gmail.com>
Signed-off-by: Jonathan Cameron <jic23@kernel.org>
drivers/iio/light/lm3533-als.c

index 5fa31a4..c1aadc6 100644 (file)
@@ -847,7 +847,7 @@ static int lm3533_als_probe(struct platform_device *pdev)
                return -EINVAL;
        }
 
-       indio_dev = iio_device_alloc(sizeof(*als));
+       indio_dev = devm_iio_device_alloc(&pdev->dev, sizeof(*als));
        if (!indio_dev)
                return -ENOMEM;
 
@@ -870,7 +870,7 @@ static int lm3533_als_probe(struct platform_device *pdev)
        if (als->irq) {
                ret = lm3533_als_setup_irq(als, indio_dev);
                if (ret)
-                       goto err_free_dev;
+                       return ret;
        }
 
        ret = lm3533_als_setup(als, pdata);
@@ -894,8 +894,6 @@ err_disable:
 err_free_irq:
        if (als->irq)
                free_irq(als->irq, indio_dev);
-err_free_dev:
-       iio_device_free(indio_dev);
 
        return ret;
 }
@@ -910,7 +908,6 @@ static int lm3533_als_remove(struct platform_device *pdev)
        lm3533_als_disable(als);
        if (als->irq)
                free_irq(als->irq, indio_dev);
-       iio_device_free(indio_dev);
 
        return 0;
 }