Since parse can do 'element name=a:b' make 'a:b.' work as well.

Original commit message from CVS:
* gst/parse/parse.l:
* testsuite/parse/parse1.c: (main):
Since parse can do 'element name=a:b' make 'a:b.' work as
well.
Added testcase to verify fix.

diff --git a/ChangeLog b/ChangeLog
index be5e708..84b5e73 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,5 +1,13 @@
 2004-10-19  Wim Taymans  <wim at fluendo dot com>
 
+       * gst/parse/parse.l:
+       * testsuite/parse/parse1.c: (main):
+       Since parse can do 'element name=a:b' make 'a:b.' work as
+       well. 
+       Added testcase to verify fix.
+
+2004-10-19  Wim Taymans  <wim at fluendo dot com>
+
        * tools/gst-inspect.c: (print_pad_info), (print_plugin_features):
        Use the realpad when printing the direction.
        Add extra \n when printing extensions of typefind factories.

diff --git a/gst/parse/parse.l b/gst/parse/parse.l
index 46ec251..5539be7 100644 (file)
--- a/gst/parse/parse.l
+++ b/gst/parse/parse.l
@@ -29,8 +29,8 @@ PRINT (const char *format, ...)
 #define YY_DECL int _gst_parse_yylex (YYSTYPE *lvalp)
 %}
 
-_operator [(){}.:!,;=]
-_identifier [[:alpha:]][[:alnum:]\-_%]*
+_operator [(){}.!,;=]
+_identifier [[:alpha:]][[:alnum:]\-_%:]*
 
 _char ("\\".)|([^[:space:]])
 _string {_char}+|("\""([^\"]|"\\\"")*"\"")|("'"([^']|"\\\"")*"'")

diff --git a/tests/old/testsuite/parse/parse1.c b/tests/old/testsuite/parse/parse1.c
index 78eb7b6..be4764a 100644 (file)
--- a/tests/old/testsuite/parse/parse1.c
+++ b/tests/old/testsuite/parse/parse1.c
@@ -100,6 +100,7 @@ static gchar *s;
 #define PIPELINE9  "fakesrc num-buffers=4 ! test. fakesink name=test"
 #define PIPELINE10 "( fakesrc num-buffers=\"4\" ! ) identity ! fakesink"
 #define PIPELINE11 "fakesink name = sink identity name=id ( fakesrc num-buffers=\"4\" ! id. ) id. ! sink."
+#define PIPELINE12 "fakesrc num-buffers=4 name=a:b  a:b. ! fakesink"
 
 gint
 main (gint argc, gchar * argv[])
@@ -216,5 +217,13 @@ main (gint argc, gchar * argv[])
   TEST_RUN;
   TEST_OK;
 
+  /**
+   * checks:
+   * - fails because a:b. is not a valid element reference in parse.l cvs rev 1.29
+   */
+  TEST_START (PIPELINE12);
+  TEST_RUN;
+  TEST_OK;
+
   return 0;
 }

diff --git a/testsuite/parse/parse1.c b/testsuite/parse/parse1.c
index 78eb7b6..be4764a 100644 (file)
--- a/testsuite/parse/parse1.c
+++ b/testsuite/parse/parse1.c
@@ -100,6 +100,7 @@ static gchar *s;
 #define PIPELINE9  "fakesrc num-buffers=4 ! test. fakesink name=test"
 #define PIPELINE10 "( fakesrc num-buffers=\"4\" ! ) identity ! fakesink"
 #define PIPELINE11 "fakesink name = sink identity name=id ( fakesrc num-buffers=\"4\" ! id. ) id. ! sink."
+#define PIPELINE12 "fakesrc num-buffers=4 name=a:b  a:b. ! fakesink"
 
 gint
 main (gint argc, gchar * argv[])
@@ -216,5 +217,13 @@ main (gint argc, gchar * argv[])
   TEST_RUN;
   TEST_OK;
 
+  /**
+   * checks:
+   * - fails because a:b. is not a valid element reference in parse.l cvs rev 1.29
+   */
+  TEST_START (PIPELINE12);
+  TEST_RUN;
+  TEST_OK;
+
   return 0;
 }