CTS failure: android.permission.cts.FileSystemPermissionTest#testAllFilesInSysAreNotW...
authorjli119X <jianpingx.li@intel.com>
Mon, 9 Apr 2012 05:17:45 +0000 (13:17 +0800)
committerbuildbot <buildbot@intel.com>
Wed, 11 Apr 2012 01:58:17 +0000 (18:58 -0700)
BZ: 20679

Remove the writeable access for others group to fix this CTS issue

Change-Id: Ie4fbd0c4645250952b9e03d61c87619edc6e03f6
Signed-off-by: jli119X <jianpingx.li@intel.com>
Reviewed-on: http://android.intel.com:8080/42759
Reviewed-by: Zhang, Hongyu <hongyu.zhang@intel.com>
Reviewed-by: Xu, Randy <randy.xu@intel.com>
Reviewed-by: Yang, Bin <bin.yang@intel.com>
Tested-by: Li, XiaojingX <xiaojingx.li@intel.com>
Reviewed-by: buildbot <buildbot@intel.com>
Tested-by: buildbot <buildbot@intel.com>
drivers/platform/x86/intel_mid_osip.c
drivers/staging/mrst/drv/psb_umevents.c

index 189b2c1..01de142 100644 (file)
@@ -643,10 +643,10 @@ static void create_debugfs_files(void)
        /* /sys/kernel/debug/osip */
        osip_dir = debugfs_create_dir("osip", NULL);
        /* /sys/kernel/debug/osip/cmdline */
-       (void) debugfs_create_file("cmdline", S_IFREG | S_IRUGO | S_IWUGO,
+       (void) debugfs_create_file("cmdline", S_IFREG | S_IRUGO | S_IWUSR | S_IWGRP,
                                   osip_dir, (void *)0, &osip_cmdline_fops);
        /* /sys/kernel/debug/osip/cmdline_pos */
-       (void) debugfs_create_file("cmdline_pos", S_IFREG | S_IRUGO | S_IWUGO,
+       (void) debugfs_create_file("cmdline_pos", S_IFREG | S_IRUGO | S_IWUSR | S_IWGRP,
                                osip_dir, (void *)1, &osip_cmdline_fops);
        /* /sys/kernel/debug/osip/decode */
        (void) debugfs_create_file("decode", S_IFREG | S_IRUGO,
index b71a839..9b578e8 100644 (file)
@@ -32,28 +32,28 @@ static const struct sysfs_ops umevent_obj_sysfs_ops = {
  *
  */
 static struct umevent_attribute data_0 =
-       __ATTR(data_0_val, 0666, psb_umevent_attr_show_imp,
+       __ATTR(data_0_val, 0664, psb_umevent_attr_show_imp,
               psb_umevent_attr_store_imp);
 static struct umevent_attribute data_1 =
-       __ATTR(data_1_val, 0666, psb_umevent_attr_show_imp,
+       __ATTR(data_1_val, 0664, psb_umevent_attr_show_imp,
               psb_umevent_attr_store_imp);
 static struct umevent_attribute data_2 =
-       __ATTR(data_2_val, 0666, psb_umevent_attr_show_imp,
+       __ATTR(data_2_val, 0664, psb_umevent_attr_show_imp,
               psb_umevent_attr_store_imp);
 static struct umevent_attribute data_3 =
-       __ATTR(data_3_val, 0666, psb_umevent_attr_show_imp,
+       __ATTR(data_3_val, 0664, psb_umevent_attr_show_imp,
               psb_umevent_attr_store_imp);
 static struct umevent_attribute data_4 =
-       __ATTR(data_4_val, 0666, psb_umevent_attr_show_imp,
+       __ATTR(data_4_val, 0664, psb_umevent_attr_show_imp,
               psb_umevent_attr_store_imp);
 static struct umevent_attribute data_5 =
-       __ATTR(data_5_val, 0666, psb_umevent_attr_show_imp,
+       __ATTR(data_5_val, 0664, psb_umevent_attr_show_imp,
               psb_umevent_attr_store_imp);
 static struct umevent_attribute data_6 =
-       __ATTR(data_6_val, 0666, psb_umevent_attr_show_imp,
+       __ATTR(data_6_val, 0664, psb_umevent_attr_show_imp,
               psb_umevent_attr_store_imp);
 static struct umevent_attribute data_7 =
-       __ATTR(data_7_val, 0666, psb_umevent_attr_show_imp,
+       __ATTR(data_7_val, 0664, psb_umevent_attr_show_imp,
               psb_umevent_attr_store_imp);
 /**
  * define the structure used to seed our ktype.