media: v4l: common: Remove v4l2_find_nearest_format
authorSakari Ailus <sakari.ailus@linux.intel.com>
Thu, 8 Feb 2018 12:00:48 +0000 (07:00 -0500)
committerMauro Carvalho Chehab <mchehab@s-opensource.com>
Wed, 21 Mar 2018 15:21:33 +0000 (11:21 -0400)
v4l2_find_nearest_format is not useful for drivers in finding the best
matching format as it assumes a V4L2 specific struct. Drivers will use
v4l2_find_nearest_size instead.

Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
drivers/media/v4l2-core/v4l2-common.c
include/media/v4l2-common.h

index 9b65529..b518b92 100644 (file)
@@ -357,32 +357,6 @@ void v4l_bound_align_image(u32 *w, unsigned int wmin, unsigned int wmax,
 }
 EXPORT_SYMBOL_GPL(v4l_bound_align_image);
 
-const struct v4l2_frmsize_discrete *
-v4l2_find_nearest_format(const struct v4l2_frmsize_discrete *sizes,
-                         size_t num_sizes,
-                         s32 width, s32 height)
-{
-       int i;
-       u32 error, min_error = UINT_MAX;
-       const struct v4l2_frmsize_discrete *size, *best = NULL;
-
-       if (!sizes)
-               return NULL;
-
-       for (i = 0, size = sizes; i < num_sizes; i++, size++) {
-               error = abs(size->width - width) + abs(size->height - height);
-               if (error < min_error) {
-                       min_error = error;
-                       best = size;
-               }
-               if (!error)
-                       break;
-       }
-
-       return best;
-}
-EXPORT_SYMBOL_GPL(v4l2_find_nearest_format);
-
 const void *
 __v4l2_find_nearest_size(const void *array, size_t array_size,
                         size_t entry_size, size_t width_offset,
index 38947dc..160bca9 100644 (file)
@@ -316,23 +316,6 @@ void v4l_bound_align_image(unsigned int *width, unsigned int wmin,
                           unsigned int salign);
 
 /**
- * v4l2_find_nearest_format - find the nearest format size among a discrete
- *     set of resolutions.
- *
- * @sizes: array of &struct v4l2_frmsize_discrete image sizes.
- * @num_sizes: length of @sizes array.
- * @width: desired width.
- * @height: desired height.
- *
- * Finds the closest resolution to minimize the width and height differences
- * between what requested and the supported resolutions.
- */
-const struct v4l2_frmsize_discrete *
-v4l2_find_nearest_format(const struct v4l2_frmsize_discrete *sizes,
-                         const size_t num_sizes,
-                         s32 width, s32 height);
-
-/**
  * v4l2_find_nearest_size - Find the nearest size among a discrete
  *     set of resolutions contained in an array of a driver specific struct.
  *