ALSA: drivers: Remove superfluous snd_pcm_suspend*() calls
authorTakashi Iwai <tiwai@suse.de>
Fri, 11 Jan 2019 17:02:20 +0000 (18:02 +0100)
committerTakashi Iwai <tiwai@suse.de>
Tue, 15 Jan 2019 16:47:06 +0000 (17:47 +0100)
The call of snd_pcm_suspend_all() & co became superfluous since we
call it in the PCM PM ops.  Let's remove them.

Reviewed-by: Jaroslav Kysela <perex@perex.cz>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
sound/drivers/aloop.c
sound/drivers/dummy.c
sound/drivers/pcsp/pcsp.c
sound/drivers/vx/vx_core.c

index 1e34e63..65c903b 100644 (file)
@@ -1200,12 +1200,8 @@ static int loopback_remove(struct platform_device *devptr)
 static int loopback_suspend(struct device *pdev)
 {
        struct snd_card *card = dev_get_drvdata(pdev);
-       struct loopback *loopback = card->private_data;
 
        snd_power_change_state(card, SNDRV_CTL_POWER_D3hot);
-
-       snd_pcm_suspend_all(loopback->pcm[0]);
-       snd_pcm_suspend_all(loopback->pcm[1]);
        return 0;
 }
        
index 9af154d..c8d3155 100644 (file)
@@ -1138,10 +1138,8 @@ static int snd_dummy_remove(struct platform_device *devptr)
 static int snd_dummy_suspend(struct device *pdev)
 {
        struct snd_card *card = dev_get_drvdata(pdev);
-       struct snd_dummy *dummy = card->private_data;
 
        snd_power_change_state(card, SNDRV_CTL_POWER_D3hot);
-       snd_pcm_suspend_all(dummy->pcm);
        return 0;
 }
        
index 0dd3f46..d83ad38 100644 (file)
@@ -197,7 +197,6 @@ static int pcsp_suspend(struct device *dev)
 {
        struct snd_pcsp *chip = dev_get_drvdata(dev);
        pcsp_stop_beep(chip);
-       snd_pcm_suspend_all(chip->pcm);
        return 0;
 }
 
index 04368dd..19496fa 100644 (file)
@@ -732,12 +732,8 @@ EXPORT_SYMBOL(snd_vx_dsp_load);
  */
 int snd_vx_suspend(struct vx_core *chip)
 {
-       unsigned int i;
-
        snd_power_change_state(chip->card, SNDRV_CTL_POWER_D3hot);
        chip->chip_status |= VX_STAT_IN_SUSPEND;
-       for (i = 0; i < chip->hw->num_codecs; i++)
-               snd_pcm_suspend_all(chip->pcm[i]);
 
        return 0;
 }