dmaengine: timb_dma: Use struct_size() in kzalloc()

One of the more common cases of allocation size calculations is finding the
size of a structure that has a zero-sized array at the end, along with memory
for some number of elements for that array. For example:

struct foo {
    int stuff;
    void *entry[];
};

instance = kzalloc(sizeof(struct foo) + sizeof(void *) * count, GFP_KERNEL);

Instead of leaving these open-coded and prone to type mistakes, we can now
use the new struct_size() helper:

instance = kzalloc(struct_size(instance, entry, count), GFP_KERNEL);

This code was detected with the help of Coccinelle.

Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Signed-off-by: Vinod Koul <vkoul@kernel.org>

diff --git a/drivers/dma/timb_dma.c b/drivers/dma/timb_dma.c
index fc0f9c8..afbb1c9 100644 (file)
--- a/drivers/dma/timb_dma.c
+++ b/drivers/dma/timb_dma.c
@@ -643,8 +643,8 @@ static int td_probe(struct platform_device *pdev)
                DRIVER_NAME))
                return -EBUSY;
 
-       td  = kzalloc(sizeof(struct timb_dma) +
-               sizeof(struct timb_dma_chan) * pdata->nr_channels, GFP_KERNEL);
+       td  = kzalloc(struct_size(td, channels, pdata->nr_channels),
+                     GFP_KERNEL);
        if (!td) {
                err = -ENOMEM;
                goto err_release_region;