Use utility function for VkViewport and VkRect2D creation
authorAri Suonpaa <ari.suonpaa@siru.fi>
Tue, 10 Apr 2018 05:31:16 +0000 (08:31 +0300)
committerAlexander Galazin <Alexander.Galazin@arm.com>
Thu, 19 Apr 2018 10:32:00 +0000 (06:32 -0400)
Use makeViewport and makeRect2D whenever possible to make code a
bit more compact.

Affects:

dEQP-VK.api.*
dEQP-VK.draw.*
dEQP-VK.dynamic_state.*
dEQP-VK.geometry.*
dEQP-VK.image.*
dEQP-VK.multiview.*
dEQP-VK.pipeline.spec_constant.*
dEQP-VK.protected_memory.*
dEQP-VK.query_pool.*
dEQP-VK.subgroups.*
dEQP-VK.synchronization.*
dEQP-VK.tessellation.*
dEQP-VK.wsi.*.incremental_present.*

Components: Vulkan, Framework

VK-GL-CTS issue: 1113

Change-Id: I7ab9fd79c67015e7a1f855c41e0b599481b9d618

35 files changed:
external/vulkancts/framework/vulkan/vkTypeUtil.hpp
external/vulkancts/modules/vulkan/api/vktApiGranularityTests.cpp
external/vulkancts/modules/vulkan/api/vktApiObjectManagementTests.cpp
external/vulkancts/modules/vulkan/draw/vktBasicDrawTests.cpp
external/vulkancts/modules/vulkan/draw/vktDrawBaseClass.cpp
external/vulkancts/modules/vulkan/draw/vktDrawDifferingInterpolationTests.cpp
external/vulkancts/modules/vulkan/draw/vktDrawInstancedTests.cpp
external/vulkancts/modules/vulkan/draw/vktDrawInvertedDepthRangesTests.cpp
external/vulkancts/modules/vulkan/draw/vktDrawNegativeViewportHeightTests.cpp
external/vulkancts/modules/vulkan/draw/vktDrawShaderViewportIndexTests.cpp
external/vulkancts/modules/vulkan/dynamic_state/vktDynamicStateBaseClass.cpp
external/vulkancts/modules/vulkan/dynamic_state/vktDynamicStateDSTests.cpp
external/vulkancts/modules/vulkan/dynamic_state/vktDynamicStateRSTests.cpp
external/vulkancts/modules/vulkan/geometry/vktGeometryTestsUtil.cpp
external/vulkancts/modules/vulkan/image/vktImageCompressionTranscodingSupport.cpp
external/vulkancts/modules/vulkan/image/vktImageTestsUtil.cpp
external/vulkancts/modules/vulkan/image/vktImageTestsUtil.hpp
external/vulkancts/modules/vulkan/multiview/vktMultiViewRenderTests.cpp
external/vulkancts/modules/vulkan/pipeline/vktPipelineSpecConstantTests.cpp
external/vulkancts/modules/vulkan/protected_memory/vktProtectedMemAttachmentClearTests.cpp
external/vulkancts/modules/vulkan/query_pool/vktQueryPoolOcclusionTests.cpp
external/vulkancts/modules/vulkan/query_pool/vktQueryPoolStatisticsTests.cpp
external/vulkancts/modules/vulkan/subgroups/vktSubgroupsTestsUtils.cpp
external/vulkancts/modules/vulkan/synchronization/vktSynchronizationInternallySynchronizedObjectsTests.cpp
external/vulkancts/modules/vulkan/synchronization/vktSynchronizationOperation.cpp
external/vulkancts/modules/vulkan/tessellation/vktTessellationCommonEdgeTests.cpp
external/vulkancts/modules/vulkan/tessellation/vktTessellationGeometryGridRenderTests.cpp
external/vulkancts/modules/vulkan/tessellation/vktTessellationGeometryPassthroughTests.cpp
external/vulkancts/modules/vulkan/tessellation/vktTessellationGeometryPointSizeTests.cpp
external/vulkancts/modules/vulkan/tessellation/vktTessellationMiscDrawTests.cpp
external/vulkancts/modules/vulkan/tessellation/vktTessellationPrimitiveDiscardTests.cpp
external/vulkancts/modules/vulkan/tessellation/vktTessellationShaderInputOutputTests.cpp
external/vulkancts/modules/vulkan/tessellation/vktTessellationUserDefinedIO.cpp
external/vulkancts/modules/vulkan/tessellation/vktTessellationWindingTests.cpp
external/vulkancts/modules/vulkan/wsi/vktWsiIncrementalPresentTests.cpp

index 73b301d..a3ccad4 100644 (file)
@@ -140,6 +140,11 @@ inline VkRect2D makeRect2D(const VkExtent2D& extent)
        return makeRect2D(0, 0, extent.width, extent.height);
 }
 
+inline VkRect2D makeRect2D(const deUint32 width, const deUint32 height)
+{
+       return makeRect2D(0, 0, width, height);
+}
+
 inline VkViewport makeViewport(const tcu::IVec2& vec)
 {
        return makeViewport(0.0f, 0.0f, (float)vec.x(), (float)vec.y(), 0.0f, 1.0f);
@@ -165,6 +170,11 @@ inline VkViewport makeViewport(const VkExtent2D& extent)
        return makeViewport(0.0f, 0.0f, (float)extent.width, (float)extent.height, 0.0f, 1.0f);
 }
 
+inline VkViewport makeViewport(const deUint32 width, const deUint32 height)
+{
+       return makeViewport(0.0f, 0.0f, (float)width, (float)height, 0.0f, 1.0f);
+}
+
 } // vk
 
 #endif // _VKTYPEUTIL_HPP
index c777042..d1cf39c 100644 (file)
@@ -34,6 +34,7 @@
 #include "vkQueryUtil.hpp"
 #include "vkRefUtil.hpp"
 #include "vkCmdUtil.hpp"
+#include "vkTypeUtil.hpp"
 #include "vktTestCase.hpp"
 
 #include "tcuTestLog.hpp"
@@ -310,11 +311,7 @@ void GranularityInstance::beginRenderPass (void)
 {
        const DeviceInterface&  vk      = m_context.getDeviceInterface();
 
-       const VkRect2D  renderArea      =
-       {
-               { 0, 0 },       // VkOffset2D    offset;
-               { 1, 1 }        // VkExtent2D   extent;
-       };
+       const VkRect2D  renderArea      = makeRect2D(1u, 1u);
 
        vk::beginRenderPass(vk, *m_cmdBuffer, *m_renderPass, *m_frameBuffer, renderArea);
 }
index 750b645..30c00bb 100644 (file)
@@ -1676,23 +1676,18 @@ struct GraphicsPipeline
                        VK_PRIMITIVE_TOPOLOGY_TRIANGLE_LIST,
                        VK_FALSE                                                                // primitiveRestartEnable
                };
-               const VkViewport                                                                viewports[]                     =
-               {
-                       { 0.0f, 0.0f, 64.f, 64.f, 0.0f, 1.0f }
-               };
-               const VkRect2D                                                                  scissors[]                      =
-               {
-                       { { 0, 0 }, { 64, 64 } }
-               };
+               const VkViewport                                                                viewport                        = makeViewport(tcu::UVec2(64));
+               const VkRect2D                                                                  scissor                         = makeRect2D(tcu::UVec2(64));
+
                const VkPipelineViewportStateCreateInfo                 viewportState           =
                {
                        VK_STRUCTURE_TYPE_PIPELINE_VIEWPORT_STATE_CREATE_INFO,
                        DE_NULL,
                        (VkPipelineViewportStateCreateFlags)0,
-                       DE_LENGTH_OF_ARRAY(viewports),
-                       viewports,
-                       DE_LENGTH_OF_ARRAY(scissors),
-                       scissors,
+                       1u,
+                       &viewport,
+                       1u,
+                       &scissor,
                };
                const VkPipelineRasterizationStateCreateInfo    rasterState                     =
                {
index 5e80ad3..acb08e7 100644 (file)
@@ -27,6 +27,7 @@
 #include "vktDrawBaseClass.hpp"
 #include "vkQueryUtil.hpp"
 #include "vkCmdUtil.hpp"
+#include "vkTypeUtil.hpp"
 #include "vktTestGroupUtil.hpp"
 
 #include "deDefs.h"
@@ -435,19 +436,8 @@ void DrawTestInstanceBase::initPipeline (const vk::VkDevice device)
 
        const PipelineCreateInfo::ColorBlendState::Attachment vkCbAttachmentState;
 
-       vk::VkViewport viewport;
-       viewport.x                              = 0;
-       viewport.y                              = 0;
-       viewport.width                  = static_cast<float>(WIDTH);
-       viewport.height                 = static_cast<float>(HEIGHT);
-       viewport.minDepth               = 0.0f;
-       viewport.maxDepth               = 1.0f;
-
-       vk::VkRect2D scissor;
-       scissor.offset.x                = 0;
-       scissor.offset.y                = 0;
-       scissor.extent.width    = WIDTH;
-       scissor.extent.height   = HEIGHT;
+       vk::VkViewport viewport = vk::makeViewport(WIDTH, HEIGHT);
+       vk::VkRect2D scissor    = vk::makeRect2D(WIDTH, HEIGHT);
 
        PipelineCreateInfo pipelineCreateInfo(*m_pipelineLayout, *m_renderPass, 0, 0);
        pipelineCreateInfo.addShader(PipelineCreateInfo::PipelineShaderStage(*vs, "main", vk::VK_SHADER_STAGE_VERTEX_BIT));
@@ -488,7 +478,7 @@ void DrawTestInstanceBase::beginRenderPass (void)
                vk::VK_PIPELINE_STAGE_COLOR_ATTACHMENT_OUTPUT_BIT,
                0, 1, &memBarrier, 0, DE_NULL, 0, DE_NULL);
 
-       const vk::VkRect2D renderArea = { { 0, 0 }, { WIDTH, HEIGHT } };
+       const vk::VkRect2D renderArea = vk::makeRect2D(WIDTH, HEIGHT);
 
        vk::beginRenderPass(m_vk, *m_cmdBuffer, *m_renderPass, *m_framebuffer, renderArea, tcu::Vec4(0.0f, 0.0f, 0.0f, 1.0f));
 }
index d616bab..9f4d083 100644 (file)
@@ -24,6 +24,7 @@
 
 #include "vktDrawBaseClass.hpp"
 #include "vkCmdUtil.hpp"
+#include "vkTypeUtil.hpp"
 
 namespace vkt
 {
@@ -155,19 +156,8 @@ void DrawTestsBaseClass::initPipeline (const vk::VkDevice device)
 
        const PipelineCreateInfo::ColorBlendState::Attachment vkCbAttachmentState;
 
-       vk::VkViewport viewport;
-       viewport.x                              = 0;
-       viewport.y                              = 0;
-       viewport.width                  = static_cast<float>(WIDTH);
-       viewport.height                 = static_cast<float>(HEIGHT);
-       viewport.minDepth               = 0.0f;
-       viewport.maxDepth               = 1.0f;
-
-       vk::VkRect2D scissor;
-       scissor.offset.x                = 0;
-       scissor.offset.y                = 0;
-       scissor.extent.width    = WIDTH;
-       scissor.extent.height   = HEIGHT;
+       vk::VkViewport viewport = vk::makeViewport(WIDTH, HEIGHT);
+       vk::VkRect2D scissor    = vk::makeRect2D(WIDTH, HEIGHT);
 
        PipelineCreateInfo pipelineCreateInfo(*m_pipelineLayout, *m_renderPass, 0, 0);
        pipelineCreateInfo.addShader(PipelineCreateInfo::PipelineShaderStage(*vs, "main", vk::VK_SHADER_STAGE_VERTEX_BIT));
@@ -208,7 +198,7 @@ void DrawTestsBaseClass::beginRenderPass (void)
                vk::VK_PIPELINE_STAGE_COLOR_ATTACHMENT_OUTPUT_BIT,
                0, 1, &memBarrier, 0, DE_NULL, 0, DE_NULL);
 
-       const vk::VkRect2D renderArea = { { 0, 0 }, { WIDTH, HEIGHT } };
+       const vk::VkRect2D renderArea = vk::makeRect2D(WIDTH, HEIGHT);
        vk::beginRenderPass(m_vk, *m_cmdBuffer, *m_renderPass, *m_framebuffer, renderArea);
 }
 
index 49b03a5..47c50ee 100644 (file)
@@ -28,6 +28,7 @@
 #include "vktDrawBaseClass.hpp"
 #include "vkQueryUtil.hpp"
 #include "vkCmdUtil.hpp"
+#include "vkTypeUtil.hpp"
 #include "vktTestGroupUtil.hpp"
 
 #include "deDefs.h"
@@ -255,19 +256,8 @@ tcu::TestStatus DrawTestInstance::iterate (void)
                        Move<VkPipelineLayout>                  pipelineLayout = createPipelineLayout(vk, device, &pipelineLayoutCreateInfo);
                        const PipelineCreateInfo::ColorBlendState::Attachment vkCbAttachmentState;
 
-                       VkViewport viewport;
-                       viewport.x                              = 0;
-                       viewport.y                              = 0;
-                       viewport.width                  = static_cast<float>(WIDTH);
-                       viewport.height                 = static_cast<float>(HEIGHT);
-                       viewport.minDepth               = 0.0f;
-                       viewport.maxDepth               = 1.0f;
-
-                       VkRect2D scissor;
-                       scissor.offset.x                = 0;
-                       scissor.offset.y                = 0;
-                       scissor.extent.width    = WIDTH;
-                       scissor.extent.height   = HEIGHT;
+                       VkViewport      viewport        = makeViewport(WIDTH, HEIGHT);
+                       VkRect2D        scissor         = makeRect2D(WIDTH, HEIGHT);
 
                        const VkVertexInputBindingDescription vertexInputBindingDescription = { 0, (deUint32)sizeof(tcu::Vec4) * 2, VK_VERTEX_INPUT_RATE_VERTEX };
 
@@ -305,7 +295,7 @@ tcu::TestStatus DrawTestInstance::iterate (void)
                                VK_ACCESS_TRANSFER_WRITE_BIT,
                                VK_ACCESS_COLOR_ATTACHMENT_READ_BIT | VK_ACCESS_COLOR_ATTACHMENT_WRITE_BIT
                        };
-                       const VkRect2D                          renderArea                      = { { 0, 0 }, { WIDTH, HEIGHT } };
+                       const VkRect2D                          renderArea                      = makeRect2D(WIDTH, HEIGHT);
                        const VkDeviceSize                      vertexBufferOffset      = 0;
                        const VkBuffer                          buffer                          = vertexBuffer->object();
                        const VkOffset3D                        zeroOffset                      = { 0, 0, 0 };
index 9feb8ae..e5ac1ee 100644 (file)
@@ -32,6 +32,7 @@
 #include "vkImageUtil.hpp"
 #include "vkPrograms.hpp"
 #include "vkCmdUtil.hpp"
+#include "vkTypeUtil.hpp"
 #include "vktDrawBufferObjectUtil.hpp"
 #include "vktDrawCreateInfoUtil.hpp"
 #include "vktDrawImageObjectUtil.hpp"
@@ -404,19 +405,8 @@ InstancedDrawInstance::InstancedDrawInstance(Context &context, TestParams params
 
        const PipelineCreateInfo::ColorBlendState::Attachment vkCbAttachmentState;
 
-       vk::VkViewport viewport;
-       viewport.x                              = 0;
-       viewport.y                              = 0;
-       viewport.width                  = static_cast<float>(WIDTH);
-       viewport.height                 = static_cast<float>(HEIGHT);
-       viewport.minDepth               = 0.0f;
-       viewport.maxDepth               = 1.0f;
-
-       vk::VkRect2D scissor;
-       scissor.offset.x                = 0;
-       scissor.offset.y                = 0;
-       scissor.extent.width    = WIDTH;
-       scissor.extent.height   = HEIGHT;
+       vk::VkViewport  viewport        = vk::makeViewport(WIDTH, HEIGHT);
+       vk::VkRect2D    scissor         = vk::makeRect2D(WIDTH, HEIGHT);
 
        PipelineCreateInfo pipelineCreateInfo(*m_pipelineLayout, *m_renderPass, 0, 0);
        pipelineCreateInfo.addShader(PipelineCreateInfo::PipelineShaderStage(*vs, "main", vk::VK_SHADER_STAGE_VERTEX_BIT));
@@ -483,7 +473,7 @@ tcu::TestStatus InstancedDrawInstance::iterate()
                                vk::VK_PIPELINE_STAGE_COLOR_ATTACHMENT_OUTPUT_BIT,
                                0, 1, &memBarrier, 0, DE_NULL, 0, DE_NULL);
 
-                       const vk::VkRect2D renderArea = { { 0, 0 }, { WIDTH, HEIGHT } };
+                       const vk::VkRect2D renderArea = vk::makeRect2D(WIDTH, HEIGHT);
                        beginRenderPass(m_vk, *m_cmdBuffer, *m_renderPass, *m_framebuffer, renderArea);
 
                        if (m_params.function == TestParams::FUNCTION_DRAW_INDEXED || m_params.function == TestParams::FUNCTION_DRAW_INDEXED_INDIRECT)
index 8c36be6..0dcf9aa 100644 (file)
@@ -198,11 +198,7 @@ InvertedDepthRangesTestInstance::InvertedDepthRangesTestInstance (Context& conte
 
        // Graphics pipeline
 
-       const VkRect2D scissor =
-       {
-               { 0,    0       },      // x, y
-               { 256,  256     },      // width, height
-       };
+       const VkRect2D scissor = makeRect2D(256u, 256u);
 
        std::vector<VkDynamicState>             dynamicStates;
        dynamicStates.push_back(VK_DYNAMIC_STATE_VIEWPORT);
index ae4a5de..b38a741 100644 (file)
@@ -199,11 +199,7 @@ NegativeViewportHeightTestInstance::NegativeViewportHeightTestInstance (Context&
 
        // Graphics pipeline
 
-       const VkRect2D scissor =
-       {
-               { 0,            0               },              // x, y
-               { WIDTH,        HEIGHT  },              // width, height
-       };
+       const VkRect2D scissor = makeRect2D(WIDTH, HEIGHT);
 
        std::vector<VkDynamicState>             dynamicStates;
        dynamicStates.push_back(VK_DYNAMIC_STATE_VIEWPORT);
index 0687adb..4d4c998 100644 (file)
@@ -257,7 +257,7 @@ Move<VkPipeline> makeGraphicsPipeline (const DeviceInterface&               vk,
        for (std::vector<UVec4>::const_iterator it = cells.begin(); it != cells.end(); ++it) {
                const VkViewport viewport = makeViewport(float(it->x()), float(it->y()), float(it->z()), float(it->w()), 0.0f, 1.0f);
                viewports.push_back(viewport);
-               const VkRect2D rect = { {0, 0}, {renderSize.x(), renderSize.y()} };
+               const VkRect2D rect = makeRect2D(renderSize);
                rectScissors.push_back(rect);
        }
 
index 775e085..ed9c3b1 100644 (file)
@@ -232,21 +232,10 @@ void DynamicStateBaseClass::beginRenderPassWithClearColor(const vk::VkClearColor
 
 void DynamicStateBaseClass::setDynamicViewportState (const deUint32 width, const deUint32 height)
 {
-       vk::VkViewport viewport;
-       viewport.x = 0;
-       viewport.y = 0;
-       viewport.width = static_cast<float>(width);
-       viewport.height = static_cast<float>(height);
-       viewport.minDepth = 0.0f;
-       viewport.maxDepth = 1.0f;
-
+       vk::VkViewport viewport = vk::makeViewport(tcu::UVec2(width, height));
        m_vk.cmdSetViewport(*m_cmdBuffer, 0, 1, &viewport);
 
-       vk::VkRect2D scissor;
-       scissor.offset.x = 0;
-       scissor.offset.y = 0;
-       scissor.extent.width = width;
-       scissor.extent.height = height;
+       vk::VkRect2D scissor = vk::makeRect2D(tcu::UVec2(width, height));
        m_vk.cmdSetScissor(*m_cmdBuffer, 0, 1, &scissor);
 }
 
index 6d90921..20a7832 100644 (file)
@@ -342,21 +342,10 @@ protected:
 
        void setDynamicViewportState (const deUint32 width, const deUint32 height)
        {
-               vk::VkViewport viewport;
-               viewport.x = 0;
-               viewport.y = 0;
-               viewport.width = static_cast<float>(width);
-               viewport.height = static_cast<float>(height);
-               viewport.minDepth = 0.0f;
-               viewport.maxDepth = 1.0f;
-
+               vk::VkViewport viewport = vk::makeViewport(tcu::UVec2(width, height));
                m_vk.cmdSetViewport(*m_cmdBuffer, 0, 1, &viewport);
 
-               vk::VkRect2D scissor;
-               scissor.offset.x = 0;
-               scissor.offset.y = 0;
-               scissor.extent.width = width;
-               scissor.extent.height = height;
+               vk::VkRect2D scissor = vk::makeRect2D(tcu::UVec2(width, height));
                m_vk.cmdSetScissor(*m_cmdBuffer, 0, 1, &scissor);
        }
 
index c4f0ef0..0bd23da 100644 (file)
@@ -317,21 +317,10 @@ protected:
 
        void setDynamicViewportState (const deUint32 width, const deUint32 height)
        {
-               vk::VkViewport viewport;
-               viewport.x = 0;
-               viewport.y = 0;
-               viewport.width = static_cast<float>(width);
-               viewport.height = static_cast<float>(height);
-               viewport.minDepth = 0.0f;
-               viewport.maxDepth = 1.0f;
-
+               vk::VkViewport viewport = vk::makeViewport(tcu::UVec2(width, height));
                m_vk.cmdSetViewport(*m_cmdBuffer, 0, 1, &viewport);
 
-               vk::VkRect2D scissor;
-               scissor.offset.x = 0;
-               scissor.offset.y = 0;
-               scissor.extent.width = width;
-               scissor.extent.height = height;
+               vk::VkRect2D scissor = vk::makeRect2D(tcu::UVec2(width, height));
                m_vk.cmdSetScissor(*m_cmdBuffer, 0, 1, &scissor);
        }
 
index f849906..25d718d 100644 (file)
@@ -182,15 +182,8 @@ Move<VkPipeline> GraphicsPipelineBuilder::build (const DeviceInterface&    vk,
                m_patchControlPoints,                                                                                   // uint32_t                                    patchControlPoints;
        };
 
-       const VkViewport viewport = makeViewport(
-               0.0f, 0.0f,
-               static_cast<float>(m_renderSize.x()), static_cast<float>(m_renderSize.y()),
-               0.0f, 1.0f);
-
-       const VkRect2D scissor = {
-               makeOffset2D(0, 0),
-               makeExtent2D(m_renderSize.x(), m_renderSize.y()),
-       };
+       const VkViewport        viewport        = makeViewport(m_renderSize);
+       const VkRect2D          scissor         = makeRect2D(m_renderSize);
 
        const VkPipelineViewportStateCreateInfo pipelineViewportStateInfo =
        {
index 0d0f100..5cbe803 100644 (file)
@@ -1547,8 +1547,8 @@ void GraphicsAttachmentsTestInstance::transcodeRead ()
                MovePtr<Buffer>                         dstImageBuffer                  = MovePtr<Buffer>(new Buffer(vk, device, allocator, dstImageBufferInfo, MemoryRequirement::HostVisible));
 
                const VkExtent2D                        renderSize                              (makeExtent2D(uncompressedImageRes.x(), uncompressedImageRes.y()));
-               const VkViewport                        viewport                                = makeViewport(0.0f, 0.0f, static_cast<float>(renderSize.width), static_cast<float>(renderSize.height), 0.0f, 1.0f);
-               const VkRect2D                          scissor                                 = makeScissor(renderSize.width, renderSize.height);
+               const VkViewport                        viewport                                = makeViewport(renderSize);
+               const VkRect2D                          scissor                                 = makeRect2D(renderSize);
 
                for (deUint32 layerNdx = 0; layerNdx < getLayerCount(); ++layerNdx)
                {
@@ -1675,8 +1675,8 @@ void GraphicsAttachmentsTestInstance::transcodeWrite ()
                const VkImageCreateInfo         srcImageCreateInfo              = makeCreateImageInfo(m_srcFormat, m_parameters.imageType, srcImageResolution, m_srcImageUsageFlags, imgCreateFlagsOverride, SINGLE_LEVEL, SINGLE_LAYER);
 
                const VkExtent2D                        renderSize                              (makeExtent2D(uncompressedImageRes.x(), uncompressedImageRes.y()));
-               const VkViewport                        viewport                                = makeViewport(0.0f, 0.0f, static_cast<float>(renderSize.width), static_cast<float>(renderSize.height), 0.0f, 1.0f);
-               const VkRect2D                          scissor                                 = makeScissor(renderSize.width, renderSize.height);
+               const VkViewport                        viewport                                = makeViewport(renderSize);
+               const VkRect2D                          scissor                                 = makeRect2D(renderSize);
 
                for (deUint32 layerNdx = 0; layerNdx < getLayerCount(); ++layerNdx)
                {
@@ -2105,8 +2105,8 @@ void GraphicsTextureTestInstance::transcodeRead ()
                MovePtr<Buffer>                         dstImageBuffer                  = MovePtr<Buffer>(new Buffer(vk, device, allocator, dstImageBufferInfo, MemoryRequirement::HostVisible));
 
                const VkExtent2D                        renderSize                              (makeExtent2D(uncompressedImageRes.x(), uncompressedImageRes.y()));
-               const VkViewport                        viewport                                = makeViewport(0.0f, 0.0f, static_cast<float>(renderSize.width), static_cast<float>(renderSize.height), 0.0f, 1.0f);
-               const VkRect2D                          scissor                                 = makeScissor(renderSize.width, renderSize.height);
+               const VkViewport                        viewport                                = makeViewport(renderSize);
+               const VkRect2D                          scissor                                 = makeRect2D(renderSize);
 
                for (deUint32 layerNdx = 0; layerNdx < getLayerCount(); ++layerNdx)
                {
@@ -2239,8 +2239,8 @@ void GraphicsTextureTestInstance::transcodeWrite ()
                const VkImageCreateInfo         srcImageCreateInfo              = makeCreateImageInfo(m_srcFormat, m_parameters.imageType, srcImageResolution, m_srcImageUsageFlags, imgCreateFlagsOverride, SINGLE_LEVEL, SINGLE_LAYER);
 
                const VkExtent2D                        renderSize                              (makeExtent2D(uncompressedImageRes.x(), uncompressedImageRes.y()));
-               const VkViewport                        viewport                                = makeViewport(0.0f, 0.0f, static_cast<float>(renderSize.width), static_cast<float>(renderSize.height), 0.0f, 1.0f);
-               const VkRect2D                          scissor                                 = makeScissor(renderSize.width, renderSize.height);
+               const VkViewport                        viewport                                = makeViewport(renderSize);
+               const VkRect2D                          scissor                                 = makeRect2D(renderSize);
 
                for (deUint32 layerNdx = 0; layerNdx < getLayerCount(); ++layerNdx)
                {
index b59049b..fd3052e 100644 (file)
@@ -1222,17 +1222,5 @@ Move<VkFramebuffer> makeFramebuffer (const DeviceInterface&      vk,
        return createFramebuffer(vk, device, &framebufferInfo);
 }
 
-VkRect2D makeScissor (const deUint32   width,
-                                         const deUint32        height)
-{
-       const VkRect2D scissor =
-       {
-               { 0u, 0u },                     // VkOffset2D   offset;
-               { width, height }       // VkExtent2D   extent;
-       };
-
-       return scissor;
-}
-
 } // image
 } // vkt
index 0c980a1..bfbf014 100644 (file)
@@ -217,9 +217,6 @@ vk::Move<vk::VkFramebuffer> makeFramebuffer (const vk::DeviceInterface&     vk,
                                                                                         const vk::VkExtent2D&          size,
                                                                                         const deUint32                         layersCount);
 
-vk::VkRect2D makeScissor (const deUint32       width,
-                                                 const deUint32        height);
-
 } // image
 } // vkt
 
index 6522fb3..87a7f4a 100644 (file)
@@ -749,21 +749,8 @@ Move<VkPipeline> MultiViewRenderTestInstance::makeGraphicsPipeline (const VkRend
                VK_FALSE,                                                                                                               // VkBool32                                                                     primitiveRestartEnable;
        };
 
-       const VkViewport                                                                viewport                                                        =
-       {
-               0.0f,                                                           // float        originX;
-               0.0f,                                                           // float        originY;
-               (float)m_parameters.extent.width,       // float        width;
-               (float)m_parameters.extent.height,      // float        height;
-               0.0f,                                                           // float        minDepth;
-               1.0f                                                            // float        maxDepth;
-       };
-
-       const VkRect2D                                                                  scissor                                                         =
-       {
-               { 0, 0 },                                                                                                       // VkOffset2D   offset;
-               { m_parameters.extent.width, m_parameters.extent.height }       // VkExtent2D   extent;
-       };
+       const VkViewport                                                                viewport                                                        = makeViewport(m_parameters.extent);
+       const VkRect2D                                                                  scissor                                                         = makeRect2D(m_parameters.extent);
 
        const VkPipelineViewportStateCreateInfo                 viewportStateParams                                     =
        {
@@ -2608,7 +2595,7 @@ void MultiViewReadbackTestInstance::beforeDraw (void)
 
 void MultiViewReadbackTestInstance::drawClears (const deUint32 subpassCount, VkRenderPass renderPass, VkFramebuffer frameBuffer, vector<PipelineSp>& pipelines, const bool clearPass)
 {
-       const VkRect2D                                  renderArea                              = { { 0, 0 }, { m_parameters.extent.width, m_parameters.extent.height } };
+       const VkRect2D                                  renderArea                              = makeRect2D(m_parameters.extent);
        const deUint32                                  drawCountPerSubpass             = (subpassCount == 1) ? m_squareCount : 1u;
        const bool                                              withClearColor                  = (clearPass && m_parameters.viewIndex == TEST_TYPE_READBACK_WITH_IMPLICIT_CLEAR);
 
index c7bb7aa..de4f7e7 100644 (file)
@@ -647,12 +647,9 @@ tcu::TestStatus GraphicsTestInstance::iterate (void)
 
        // Draw commands
 
-       const VkRect2D renderArea = {
-               makeOffset2D(0, 0),
-               makeExtent2D(renderSize.x(), renderSize.y()),
-       };
-       const tcu::Vec4    clearColor         (0.0f, 0.0f, 0.0f, 1.0f);
-       const VkDeviceSize vertexBufferOffset = 0ull;
+       const VkRect2D          renderArea                      = makeRect2D(renderSize);
+       const tcu::Vec4         clearColor                      (0.0f, 0.0f, 0.0f, 1.0f);
+       const VkDeviceSize      vertexBufferOffset      = 0ull;
 
        beginCommandBuffer(vk, *cmdBuffer);
 
index 4f80e23..8aa8c42 100644 (file)
@@ -184,7 +184,7 @@ tcu::TestStatus AttachmentClearTestInstance::iterate()
        const vk::VkSubpassContents                     subpassContents         = m_cmdBufferType == CMD_BUFFER_SECONDARY
                                                                                                                          ? vk::VK_SUBPASS_CONTENTS_SECONDARY_COMMAND_BUFFERS
                                                                                                                          : vk::VK_SUBPASS_CONTENTS_INLINE;
-       beginRenderPass(vk, *cmdBuffer, *renderPass, *framebuffer, vk::makeRect2D(0, 0, RENDER_WIDTH, RENDER_HEIGHT), clearValue, subpassContents);
+       beginRenderPass(vk, *cmdBuffer, *renderPass, *framebuffer, vk::makeRect2D(RENDER_WIDTH, RENDER_HEIGHT), clearValue, subpassContents);
 
        if (m_cmdBufferType == CMD_BUFFER_SECONDARY)
        {
@@ -210,21 +210,7 @@ tcu::TestStatus AttachmentClearTestInstance::iterate()
                        0u,                                                                                                     //uint32_t                              colorAttachment
                        m_clearValue                                                                            // VkClearValue                 clearValue;
                };
-               const vk::VkOffset2D                    offset                          =
-               {
-                       0,                                                                                                      //int32_t                               x;
-                       0                                                                                                       //int32_t                               y;
-               };
-               const vk::VkExtent2D                    extent                          =
-               {
-                       RENDER_WIDTH,                                                                           //uint32_t                              width;
-                       RENDER_HEIGHT                                                                           //uint32_t                              height;
-               };
-               const vk::VkRect2D                              rect2D                          =
-               {
-                       offset,                                                                                         //VkOffset2D                    offset;
-                       extent                                                                                          //VkExtent2D                    extent;
-               };
+               const vk::VkRect2D                              rect2D                          = vk::makeRect2D(RENDER_WIDTH, RENDER_HEIGHT);
                const vk::VkClearRect                   clearRect                       =
                {
                        rect2D,                                                                                         // VkRect2D                             rect;
index 2a38202..657a216 100644 (file)
@@ -211,27 +211,8 @@ StateObjects::StateObjects (const vk::DeviceInterface&vk, vkt::Context &context,
                pipelineCreateInfo.addShader(PipelineCreateInfo::PipelineShaderStage(*fs, "main", vk::VK_SHADER_STAGE_FRAGMENT_BIT));
                pipelineCreateInfo.addState(PipelineCreateInfo::InputAssemblerState(primitive));
                pipelineCreateInfo.addState(PipelineCreateInfo::ColorBlendState(1, &attachmentState));
-               const vk::VkViewport viewport   =
-               {
-                       0,              // float x;
-                       0,              // float y;
-                       WIDTH,  // float width;
-                       HEIGHT, // float height;
-                       0.0f,   // float minDepth;
-                       1.0f    // float maxDepth;
-               };
-
-               const vk::VkRect2D scissor              =
-               {
-                       {
-                               0,              // deInt32 x
-                               0,              // deInt32 y
-                       },              // VkOffset2D   offset;
-                       {
-                               WIDTH,  // deInt32 width;
-                               HEIGHT, // deInt32 height
-                       },              // VkExtent2D   extent;
-               };
+               const vk::VkViewport viewport   = vk::makeViewport(WIDTH, HEIGHT);
+               const vk::VkRect2D scissor              = vk::makeRect2D(WIDTH, HEIGHT);
                pipelineCreateInfo.addState(PipelineCreateInfo::ViewportState(1, std::vector<vk::VkViewport>(1, viewport), std::vector<vk::VkRect2D>(1, scissor)));
                pipelineCreateInfo.addState(PipelineCreateInfo::DepthStencilState(true, true, vk::VK_COMPARE_OP_GREATER_OR_EQUAL));
                pipelineCreateInfo.addState(PipelineCreateInfo::RasterizerState());
index 0441782..23fb43b 100644 (file)
@@ -933,27 +933,8 @@ void VertexShaderTestInstance::createPipeline (void)
        pipelineCreateInfo.addState(PipelineCreateInfo::InputAssemblerState(m_parametersGraphic.primitiveTopology));
        pipelineCreateInfo.addState(PipelineCreateInfo::ColorBlendState(1, &attachmentState));
 
-       const VkViewport        viewport        =
-       {
-               0.0f,           // float x;
-               0.0f,           // float y;
-               WIDTH,  // float width;
-               HEIGHT, // float height;
-               0.0f,   // float minDepth;
-               1.0f    // float maxDepth;
-       };
-
-       const VkRect2D          scissor         =
-       {
-               {
-                       0,              // deInt32 x
-                       0,              // deInt32 y
-               },              // VkOffset2D   offset;
-               {
-                       WIDTH,  // deInt32 width;
-                       HEIGHT, // deInt32 height
-               },              // VkExtent2D   extent;
-       };
+       const VkViewport        viewport        = makeViewport(WIDTH, HEIGHT);
+       const VkRect2D          scissor         = makeRect2D(WIDTH, HEIGHT);
        pipelineCreateInfo.addState(PipelineCreateInfo::ViewportState(1u, std::vector<VkViewport>(1, viewport), std::vector<VkRect2D>(1, scissor)));
        pipelineCreateInfo.addState(PipelineCreateInfo::DepthStencilState());
        pipelineCreateInfo.addState(PipelineCreateInfo::RasterizerState());
@@ -1316,27 +1297,9 @@ void GeometryShaderTestInstance::createPipeline (void)
        pipelineCreateInfo.addState(PipelineCreateInfo::InputAssemblerState(m_parametersGraphic.primitiveTopology));
        pipelineCreateInfo.addState(PipelineCreateInfo::ColorBlendState(1, &attachmentState));
 
-       const VkViewport        viewport        =
-       {
-               0.0f,           // float x;
-               0.0f,           // float y;
-               WIDTH,  // float width;
-               HEIGHT, // float height;
-               0.0f,   // float minDepth;
-               1.0f    // float maxDepth;
-       };
+       const VkViewport        viewport        = makeViewport(WIDTH, HEIGHT);
+       const VkRect2D          scissor         = makeRect2D(WIDTH, HEIGHT);
 
-       const VkRect2D          scissor         =
-       {
-               {
-                       0,              // deInt32 x
-                       0,              // deInt32 y
-               },              // VkOffset2D   offset;
-               {
-                       WIDTH,  // deInt32 width;
-                       HEIGHT, // deInt32 height
-               },              // VkExtent2D   extent;
-       };
        pipelineCreateInfo.addState(PipelineCreateInfo::ViewportState(1, std::vector<VkViewport>(1, viewport), std::vector<VkRect2D>(1, scissor)));
 
        if (m_context.getDeviceFeatures().depthBounds)
@@ -1690,27 +1653,9 @@ void TessellationShaderTestInstance::createPipeline (void)
        pipelineCreateInfo.addState(PipelineCreateInfo::InputAssemblerState(VK_PRIMITIVE_TOPOLOGY_PATCH_LIST));
        pipelineCreateInfo.addState(PipelineCreateInfo::ColorBlendState(1, &attachmentState));
 
-       const VkViewport        viewport        =
-       {
-               0.0f,           // float x;
-               0.0f,           // float y;
-               WIDTH,  // float width;
-               HEIGHT, // float height;
-               0.0f,   // float minDepth;
-               1.0f    // float maxDepth;
-       };
+       const VkViewport        viewport        = makeViewport(WIDTH, HEIGHT);
+       const VkRect2D          scissor         = makeRect2D(WIDTH, HEIGHT);
 
-       const VkRect2D          scissor         =
-       {
-               {
-                       0,              // deInt32 x
-                       0,              // deInt32 y
-               },              // VkOffset2D   offset;
-               {
-                       WIDTH,  // deInt32 width;
-                       HEIGHT, // deInt32 height
-               },              // VkExtent2D   extent;
-       };
        pipelineCreateInfo.addState(PipelineCreateInfo::ViewportState(1, std::vector<VkViewport>(1, viewport), std::vector<VkRect2D>(1, scissor)));
        pipelineCreateInfo.addState(PipelineCreateInfo::DepthStencilState());
        pipelineCreateInfo.addState(PipelineCreateInfo::RasterizerState());
index 56d90f8..cc4f902 100644 (file)
@@ -1653,8 +1653,8 @@ tcu::TestStatus vkt::subgroups::makeTessellationEvaluationFrameBufferTest(
        for (deUint32 width = 1u; width < maxWidth; ++width)
        {
                const Unique<VkFramebuffer>     framebuffer                     (makeFramebuffer(context, *renderPass, discardableImage.getImageView(), maxWidth, 1));
-               const VkViewport                        viewport                        = {0.0f, 0.0f, static_cast<float>(maxWidth), 1.0f, 0.0f, 1.0f};
-               const VkRect2D                          scissor                         = {{0, 0}, {maxWidth, 1}};
+               const VkViewport                        viewport                        = makeViewport(maxWidth, 1u);
+               const VkRect2D                          scissor                         = makeRect2D(maxWidth, 1u);
                const vk::VkDeviceSize          imageResultSize         = tcu::getPixelSize(vk::mapVkFormat(format)) * maxWidth;
                Buffer                                          imageBufferResult       (context, imageResultSize, VK_BUFFER_USAGE_TRANSFER_DST_BIT);
                const VkDeviceSize                      vertexBufferOffset      = 0u;
@@ -1870,8 +1870,8 @@ tcu::TestStatus vkt::subgroups::makeGeometryFrameBufferTest(
        {
                totalIterations++;
                const Unique<VkFramebuffer>     framebuffer                     (makeFramebuffer(context, *renderPass, discardableImage.getImageView(), maxWidth, 1));
-               const VkViewport                        viewport                        = {0.0f, 0.0f, static_cast<float>(maxWidth), 1.0f, 0.0f, 1.0f};
-               const VkRect2D                          scissor                         = {{0, 0}, {maxWidth, 1}};
+               const VkViewport                        viewport                        = makeViewport(maxWidth, 1u);
+               const VkRect2D                          scissor                         = makeRect2D(maxWidth, 1u);
                const vk::VkDeviceSize          imageResultSize         = tcu::getPixelSize(vk::mapVkFormat(format)) * maxWidth;
                Buffer                                          imageBufferResult       (context, imageResultSize, VK_BUFFER_USAGE_TRANSFER_DST_BIT);
                const VkDeviceSize                      vertexBufferOffset      = 0u;
@@ -2162,8 +2162,8 @@ tcu::TestStatus vkt::subgroups::allStages(
                const VkDeviceSize                              resultImageSizeInBytes  = maxWidth * 1 * getFormatSizeInBytes(format);
                Image                                                   resultImage                             (context, maxWidth, 1, format, VK_IMAGE_USAGE_COLOR_ATTACHMENT_BIT | VK_IMAGE_USAGE_TRANSFER_SRC_BIT);
                const Unique<VkFramebuffer>             framebuffer                             (makeFramebuffer(context, *renderPass, resultImage.getImageView(), maxWidth, 1));
-               const VkViewport                                viewport                                = {0.0f, 0.0f, static_cast<float>(maxWidth), 1.0f, 0.0f, 1.0f};
-               const VkRect2D                                  scissor                                 = {{0, 0}, {maxWidth, 1}};
+               const VkViewport                                viewport                                = makeViewport(maxWidth, 1u);
+               const VkRect2D                                  scissor                                 = makeRect2D(maxWidth, 1u);
                const vk::VkDeviceSize                  imageResultSize                 = tcu::getPixelSize(vk::mapVkFormat(format)) * maxWidth;
                Buffer                                                  imageBufferResult               (context, imageResultSize, VK_BUFFER_USAGE_TRANSFER_DST_BIT);
                const VkImageSubresourceRange   subresourceRange                =
@@ -2446,8 +2446,8 @@ tcu::TestStatus vkt::subgroups::makeVertexFrameBufferTest(Context& context, vk::
        {
                totalIterations++;
                const Unique<VkFramebuffer>     framebuffer                     (makeFramebuffer(context, *renderPass, discardableImage.getImageView(), maxWidth, 1));
-               const VkViewport                        viewport                        = {0.0f, 0.0f, static_cast<float>(maxWidth), 1.0f, 0.0f, 1.0f};
-               const VkRect2D                          scissor                         = {{0, 0}, {maxWidth, 1}};
+               const VkViewport                        viewport                        = makeViewport(maxWidth, 1u);
+               const VkRect2D                          scissor                         = makeRect2D(maxWidth, 1u);
                const vk::VkDeviceSize          imageResultSize         = tcu::getPixelSize(vk::mapVkFormat(format)) * maxWidth;
                Buffer                                          imageBufferResult       (context, imageResultSize, VK_BUFFER_USAGE_TRANSFER_DST_BIT);
                const VkDeviceSize                      vertexBufferOffset      = 0u;
@@ -2683,9 +2683,7 @@ tcu::TestStatus vkt::subgroups::makeFragmentFrameBufferTest       (Context& context, V
 
                        beginCommandBuffer(context.getDeviceInterface(), *cmdBuffer);
 
-                       VkViewport viewport = {0.0f, 0.0f, static_cast<float>(width),
-                                                                  static_cast<float>(height), 0.0f, 1.0f
-                                                                 };
+                       VkViewport viewport = makeViewport(width, height);
 
                        context.getDeviceInterface().cmdSetViewport(
                                *cmdBuffer, 0, 1, &viewport);
index dcd132a..ec80b66 100644 (file)
@@ -399,11 +399,7 @@ TestStatus executeGraphicPipeline (const Context& context, const VkPipeline& pip
                }
 
                {
-                       const VkRect2D  renderArea      =
-                                                                               {
-                                                                                       makeOffset2D(0, 0),
-                                                                                       makeExtent2D(1, 1),
-                                                                               };
+                       const VkRect2D  renderArea      = makeRect2D(1u, 1u);
                        const tcu::Vec4 clearColor      = tcu::Vec4(0.0f, 0.0f, 0.0f, 1.0f);
                        beginRenderPass(vk, *cmdBuffer, renderPass, *framebuffer, renderArea, clearColor);
                }
index ee049b5..ba22420 100644 (file)
@@ -1040,11 +1040,8 @@ public:
                }
 
                {
-                       const VkRect2D renderArea = {
-                               makeOffset2D(0, 0),
-                               makeExtent2D(m_colorImageExtent.width, m_colorImageExtent.height),
-                       };
-                       const tcu::Vec4 clearColor = tcu::Vec4(0.0f, 0.0f, 0.0f, 1.0f);
+                       const VkRect2D  renderArea      = makeRect2D(m_colorImageExtent);
+                       const tcu::Vec4 clearColor      = tcu::Vec4(0.0f, 0.0f, 0.0f, 1.0f);
 
                        beginRenderPass(vk, cmdBuffer, *m_renderPass, *m_framebuffer, renderArea, clearColor);
                }
@@ -2355,11 +2352,8 @@ public:
                }
 
                {
-                       const VkRect2D renderArea = {
-                               makeOffset2D(0, 0),
-                               makeExtent2D(m_attachmentExtent.width, m_attachmentExtent.height),
-                       };
-                       const tcu::Vec4 clearColor = tcu::Vec4(0.0f, 0.0f, 0.0f, 1.0f);
+                       const VkRect2D  renderArea      = makeRect2D(m_attachmentExtent);
+                       const tcu::Vec4 clearColor      = tcu::Vec4(0.0f, 0.0f, 0.0f, 1.0f);
 
                        beginRenderPass(vk, cmdBuffer, *m_renderPass, *m_framebuffer, renderArea, clearColor);
                }
@@ -2572,11 +2566,7 @@ public:
                        m_clearValue                                                                            // VkClearValue                 clearValue;
                };
 
-               const VkRect2D                  rect2D                  =
-               {
-                       { 0u, 0u, },                                                                                                                                    //      VkOffset2D      offset;
-                       { m_resource.getImage().extent.width, m_resource.getImage().extent.height },    //      VkExtent2D      extent;
-               };
+               const VkRect2D                  rect2D                  = makeRect2D(m_resource.getImage().extent);
 
                const VkClearRect               clearRect               =
                {
@@ -2736,11 +2726,8 @@ public:
                }
 
                {
-                       const VkRect2D renderArea = {
-                               makeOffset2D(0, 0),
-                               makeExtent2D(m_colorImageExtent.width, m_colorImageExtent.height),
-                       };
-                       const tcu::Vec4 clearColor = tcu::Vec4(0.0f, 0.0f, 0.0f, 1.0f);
+                       const VkRect2D  renderArea      = makeRect2D(m_colorImageExtent);
+                       const tcu::Vec4 clearColor      = tcu::Vec4(0.0f, 0.0f, 0.0f, 1.0f);
 
                        beginRenderPass(vk, cmdBuffer, *m_renderPass, *m_framebuffer, renderArea, clearColor);
                }
@@ -3203,11 +3190,8 @@ public:
                }
 
                {
-                       const VkRect2D renderArea = {
-                               makeOffset2D(0, 0),
-                               makeExtent2D(m_colorImageExtent.width, m_colorImageExtent.height),
-                       };
-                       const tcu::Vec4 clearColor = tcu::Vec4(0.0f, 0.0f, 0.0f, 1.0f);
+                       const VkRect2D  renderArea      = makeRect2D(m_colorImageExtent);
+                       const tcu::Vec4 clearColor      = tcu::Vec4(0.0f, 0.0f, 0.0f, 1.0f);
 
                        beginRenderPass(vk, cmdBuffer, *m_renderPass, *m_framebuffer, renderArea, clearColor);
                }
index 3de78d2..35e86c8 100644 (file)
@@ -401,11 +401,8 @@ tcu::TestStatus test (Context& context, const CaseDefinition caseDef)
 
        // Begin render pass
        {
-               const VkRect2D renderArea = {
-                       makeOffset2D(0, 0),
-                       makeExtent2D(renderSize.x(), renderSize.y()),
-               };
-               const tcu::Vec4 clearColor(0.0f, 0.0f, 0.0f, 1.0f);
+               const VkRect2D  renderArea      = makeRect2D(renderSize);
+               const tcu::Vec4 clearColor      (0.0f, 0.0f, 0.0f, 1.0f);
 
                beginRenderPass(vk, *cmdBuffer, *renderPass, *framebuffer, renderArea, clearColor);
        }
index f7e93b7..274cc00 100644 (file)
@@ -584,11 +584,8 @@ tcu::TestStatus GridRenderTestInstance::iterate (void)
 
        // Begin render pass
        {
-               const VkRect2D renderArea = {
-                       makeOffset2D(0, 0),
-                       makeExtent2D(renderSize.x(), renderSize.y()),
-               };
-               const tcu::Vec4 clearColor(0.0f, 0.0f, 0.0f, 1.0f);
+               const VkRect2D  renderArea      = makeRect2D(renderSize);
+               const tcu::Vec4 clearColor      (0.0f, 0.0f, 0.0f, 1.0f);
 
                beginRenderPass(vk, *cmdBuffer, *renderPass, *framebuffer, renderArea, clearColor);
        }
index d410189..4f116d1 100644 (file)
@@ -549,11 +549,8 @@ tcu::TestStatus PassthroughTestInstance::iterate (void)
 
                // Begin render pass
                {
-                       const VkRect2D renderArea = {
-                               makeOffset2D(0, 0),
-                               makeExtent2D(renderSize.x(), renderSize.y()),
-                       };
-                       const tcu::Vec4 clearColor(0.0f, 0.0f, 0.0f, 1.0f);
+                       const VkRect2D  renderArea      = makeRect2D(renderSize);
+                       const tcu::Vec4 clearColor      (0.0f, 0.0f, 0.0f, 1.0f);
 
                        beginRenderPass(vk, *cmdBuffer, *renderPass, *framebuffer, renderArea, clearColor);
                }
index b83b64c..a10fa6f 100644 (file)
@@ -371,11 +371,8 @@ tcu::TestStatus test (Context& context, const Flags flags)
 
        // Begin render pass
        {
-               const VkRect2D renderArea = {
-                       makeOffset2D(0, 0),
-                       makeExtent2D(renderSize.x(), renderSize.y()),
-               };
-               const tcu::Vec4 clearColor(0.0f, 0.0f, 0.0f, 1.0f);
+               const VkRect2D  renderArea      = makeRect2D(renderSize);
+               const tcu::Vec4 clearColor      (0.0f, 0.0f, 0.0f, 1.0f);
 
                beginRenderPass(vk, *cmdBuffer, *renderPass, *framebuffer, renderArea, clearColor);
        }
index b4e55aa..a99f0df 100644 (file)
@@ -253,11 +253,8 @@ tcu::TestStatus runTest (Context& context, const CaseDefinition caseDef)
 
                // Begin render pass
                {
-                       const VkRect2D renderArea = {
-                               makeOffset2D(0, 0),
-                               makeExtent2D(renderSize.x(), renderSize.y()),
-                       };
-                       const tcu::Vec4 clearColor(0.0f, 0.0f, 0.0f, 1.0f);
+                       const VkRect2D  renderArea      = makeRect2D(renderSize);
+                       const tcu::Vec4 clearColor      (0.0f, 0.0f, 0.0f, 1.0f);
 
                        beginRenderPass(vk, *cmdBuffer, *renderPass, *framebuffer, renderArea, clearColor);
                }
index 170928c..1f65f11 100644 (file)
@@ -505,11 +505,8 @@ tcu::TestStatus test (Context& context, const CaseDefinition caseDef)
 
        // Begin render pass
        {
-               const VkRect2D renderArea = {
-                       makeOffset2D(0, 0),
-                       makeExtent2D(renderSize.x(), renderSize.y()),
-               };
-               const tcu::Vec4 clearColor = tcu::Vec4(0.0f, 0.0f, 0.0f, 1.0f);
+               const VkRect2D  renderArea      = makeRect2D(renderSize);
+               const tcu::Vec4 clearColor      = tcu::Vec4(0.0f, 0.0f, 0.0f, 1.0f);
 
                beginRenderPass(vk, *cmdBuffer, *renderPass, *framebuffer, renderArea, clearColor);
        }
index e9f02a1..84bfa43 100644 (file)
@@ -149,11 +149,8 @@ tcu::TestStatus runTest (Context&                                                  context,
 
        // Begin render pass
        {
-               const VkRect2D renderArea = {
-                       makeOffset2D(0, 0),
-                       makeExtent2D(renderSize.x(), renderSize.y()),
-               };
-               const tcu::Vec4 clearColor(0.0f, 0.0f, 0.0f, 1.0f);
+               const VkRect2D  renderArea      = makeRect2D(renderSize);
+               const tcu::Vec4 clearColor      (0.0f, 0.0f, 0.0f, 1.0f);
 
                beginRenderPass(vk, *cmdBuffer, *renderPass, *framebuffer, renderArea, clearColor);
        }
index 5d83427..6642cb3 100644 (file)
@@ -860,10 +860,7 @@ tcu::TestStatus UserDefinedIOTestInstance::iterate (void)
        }
 
        {
-               const VkRect2D renderArea = {
-                       makeOffset2D(0, 0),
-                       makeExtent2D(renderSize.x(), renderSize.y()),
-               };
+               const VkRect2D renderArea = makeRect2D(renderSize);
                const tcu::Vec4 clearColor(0.0f, 0.0f, 0.0f, 1.0f);
 
                beginRenderPass(vk, *cmdBuffer, *renderPass, *framebuffer, renderArea, clearColor);
index cab1515..59fb026 100644 (file)
@@ -506,11 +506,8 @@ tcu::TestStatus WindingTestInstance::iterate (void)
 
                // Begin render pass
                {
-                       const VkRect2D renderArea = {
-                               makeOffset2D(0, 0),
-                               makeExtent2D(renderSize.x(), renderSize.y()),
-                       };
-                       const tcu::Vec4 clearColor = tcu::RGBA::red().toVec();
+                       const VkRect2D  renderArea      = makeRect2D(renderSize);
+                       const tcu::Vec4 clearColor      = tcu::RGBA::red().toVec();
 
                        beginRenderPass(vk, *cmdBuffer, *renderPass, *framebuffer, renderArea, clearColor);
                }
@@ -526,11 +523,7 @@ tcu::TestStatus WindingTestInstance::iterate (void)
                };
                vk.cmdSetViewport(*cmdBuffer, 0, 1, &viewport);
 
-               const VkRect2D scissor =
-               {
-                       makeOffset2D(0, 0),
-                       makeExtent2D(renderSize.x(), renderSize.y()),
-               };
+               const VkRect2D scissor = makeRect2D(renderSize);
                vk.cmdSetScissor(*cmdBuffer, 0, 1, &scissor);
 
                vk.cmdBindPipeline(*cmdBuffer, VK_PIPELINE_BIND_POINT_GRAPHICS, testCases[caseNdx].pipeline);
index 48c5bd3..1c5b2c5 100644 (file)
@@ -328,12 +328,7 @@ void cmdRenderFrame (const vk::DeviceInterface&    vkd,
 
        if (frameNdx == 0)
        {
-               const vk::VkRect2D      scissor =
-               {
-                       { 0u, 0u },
-                       { imageWidth, imageHeight }
-               };
-
+               const vk::VkRect2D      scissor = vk::makeRect2D(imageWidth, imageHeight);
                vkd.cmdSetScissor(commandBuffer, 0u, 1u, &scissor);
                const vk::VkClearAttachment     attachment      =
                {
@@ -413,7 +408,7 @@ vk::Move<vk::VkCommandBuffer> createCommandBuffer (const vk::DeviceInterface&       vk
                vkd.cmdPipelineBarrier(*commandBuffer, vk::VK_PIPELINE_STAGE_COLOR_ATTACHMENT_OUTPUT_BIT, vk::VK_PIPELINE_STAGE_COLOR_ATTACHMENT_OUTPUT_BIT, 0, 0, DE_NULL, 0, DE_NULL, 1, &barrier);
        }
 
-       beginRenderPass(vkd, *commandBuffer, renderPass, framebuffer, vk::makeRect2D(0, 0, imageWidth, imageHeight), tcu::Vec4(0.25f, 0.5f, 0.75f, 1.0f));
+       beginRenderPass(vkd, *commandBuffer, renderPass, framebuffer, vk::makeRect2D(imageWidth, imageHeight), tcu::Vec4(0.25f, 0.5f, 0.75f, 1.0f));
 
        for (size_t frameNdx = imageNextFrame; frameNdx <= currentFrame; frameNdx++)
                cmdRenderFrame(vkd, *commandBuffer, pipelineLayout, pipeline, frameNdx, imageWidth, imageHeight);