gxt4500: fix color order
authorOndrej Zary <linux@rainbow-software.org>
Thu, 1 Oct 2015 21:22:53 +0000 (23:22 +0200)
committerTomi Valkeinen <tomi.valkeinen@ti.com>
Thu, 8 Oct 2015 09:19:39 +0000 (12:19 +0300)
The color order in truecolor modes is wrong. This does not affect console but
is visible e.g. in X11 which has wrong colors.

Swap blue and red colors to fix the problem.
Fixes https://forums.gentoo.org/viewtopic-t-692740-start-0.html

Signed-off-by: Ondrej Zary <linux@rainbow-software.org>
Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
drivers/video/fbdev/gxt4500.c

index 3c481d0..3ceddb8 100644 (file)
@@ -347,11 +347,12 @@ static void gxt4500_unpack_pixfmt(struct fb_var_screeninfo *var,
                break;
        }
        if (pixfmt != DFA_PIX_8BIT) {
-               var->green.offset = var->red.length;
-               var->blue.offset = var->green.offset + var->green.length;
+               var->blue.offset = 0;
+               var->green.offset = var->blue.length;
+               var->red.offset = var->green.offset + var->green.length;
                if (var->transp.length)
                        var->transp.offset =
-                               var->blue.offset + var->blue.length;
+                               var->red.offset + var->red.length;
        }
 }