projects
/
platform
/
kernel
/
linux-rpi.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
15fd395
)
debugfs: debugfs_create_file_size(): use IS_ERR to check for error
author
Nirmoy Das
<nirmoy.das@amd.com>
Thu, 2 Sep 2021 10:29:17 +0000
(12:29 +0200)
committer
Greg Kroah-Hartman
<gregkh@linuxfoundation.org>
Wed, 6 Oct 2021 13:55:59 +0000
(15:55 +0200)
commit
af505cad9567f7a500d34bf183696d570d7f6810
upstream.
debugfs_create_file() returns encoded error so use IS_ERR for checking
return value.
Reviewed-by: Christian König <christian.koenig@amd.com>
Signed-off-by: Nirmoy Das <nirmoy.das@amd.com>
Fixes:
ff9fb72bc077
("debugfs: return error values, not NULL")
Cc: stable <stable@vger.kernel.org>
References: https://gitlab.freedesktop.org/drm/amd/-/issues/1686
Link:
https://lore.kernel.org/r/20210902102917.2233-1-nirmoy.das@amd.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
fs/debugfs/inode.c
patch
|
blob
|
history
diff --git
a/fs/debugfs/inode.c
b/fs/debugfs/inode.c
index
720d65f
..
848e0aa
100644
(file)
--- a/
fs/debugfs/inode.c
+++ b/
fs/debugfs/inode.c
@@
-524,7
+524,7
@@
void debugfs_create_file_size(const char *name, umode_t mode,
{
struct dentry *de = debugfs_create_file(name, mode, parent, data, fops);
- if (
de
)
+ if (
!IS_ERR(de)
)
d_inode(de)->i_size = file_size;
}
EXPORT_SYMBOL_GPL(debugfs_create_file_size);