crypto: nx - Add of_node_put() before return in 842
authorNishka Dasgupta <nishkadg.linux@gmail.com>
Wed, 24 Jul 2019 07:54:33 +0000 (13:24 +0530)
committerHerbert Xu <herbert@gondor.apana.org.au>
Fri, 2 Aug 2019 04:44:32 +0000 (14:44 +1000)
Each iteration of for_each_compatible_node puts the previous node, but
in the case of a return from the middle of the loop, there is no put,
thus causing a memory leak. Add an of_node_put before the return.
Issue found with Coccinelle.

Acked-by: Stewart Smith <stewart@linux.ibm.com>
Signed-off-by: Nishka Dasgupta <nishkadg.linux@gmail.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
drivers/crypto/nx/nx-842-powernv.c

index e78ff5c..c037a24 100644 (file)
@@ -1020,6 +1020,7 @@ static __init int nx842_powernv_init(void)
                ret = nx842_powernv_probe_vas(dn);
                if (ret) {
                        nx842_delete_coprocs();
+                       of_node_put(dn);
                        return ret;
                }
        }