pwm: tegra: Don't needlessly enable and disable the clock in .remove()
authorUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Thu, 17 Jun 2021 09:51:42 +0000 (11:51 +0200)
committerThierry Reding <thierry.reding@gmail.com>
Wed, 30 Jun 2021 17:12:20 +0000 (19:12 +0200)
There is no reason to enable the PWM clock just to assert the reset
control. (If the reset control depends on the clock this is a bug and
probably it doesn't because in .probe() the reset is deasserted without
the clock being enabled.)

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: Thierry Reding <thierry.reding@gmail.com>
drivers/pwm/pwm-tegra.c

index a051cf4..e865743 100644 (file)
@@ -300,14 +300,8 @@ static int tegra_pwm_probe(struct platform_device *pdev)
 static int tegra_pwm_remove(struct platform_device *pdev)
 {
        struct tegra_pwm_chip *pc = platform_get_drvdata(pdev);
-       int err;
-
-       err = clk_prepare_enable(pc->clk);
-       if (err < 0)
-               return err;
 
        reset_control_assert(pc->rst);
-       clk_disable_unprepare(pc->clk);
 
        return pwmchip_remove(&pc->chip);
 }