media: cec-gpio: specify IRQF_NO_AUTOEN when requesting irq
authorHans Verkuil <hverkuil-cisco@xs4all.nl>
Fri, 7 Jul 2023 11:26:38 +0000 (13:26 +0200)
committerMauro Carvalho Chehab <mchehab@kernel.org>
Thu, 10 Aug 2023 05:58:32 +0000 (07:58 +0200)
Use IRQF_NO_AUTOEN rather than manually disabling the requested
interrupt.

Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>
drivers/media/cec/platform/cec-gpio/cec-gpio.c

index ff34490..6413c0e 100644 (file)
@@ -215,13 +215,11 @@ static int cec_gpio_probe(struct platform_device *pdev)
                return PTR_ERR(cec->adap);
 
        ret = devm_request_irq(dev, cec->cec_irq, cec_gpio_irq_handler,
-                              IRQF_TRIGGER_RISING | IRQF_TRIGGER_FALLING,
+                              IRQF_TRIGGER_RISING | IRQF_TRIGGER_FALLING | IRQF_NO_AUTOEN,
                               cec->adap->name, cec);
        if (ret)
                goto del_adap;
 
-       cec_gpio_disable_irq(cec->adap);
-
        if (cec->hpd_gpio) {
                cec->hpd_irq = gpiod_to_irq(cec->hpd_gpio);
                ret = devm_request_threaded_irq(dev, cec->hpd_irq,