pvr: do not use fallthrough for unreachable code
authorErik Faye-Lund <erik.faye-lund@collabora.com>
Wed, 23 Mar 2022 17:34:26 +0000 (18:34 +0100)
committerMarge Bot <emma+marge@anholt.net>
Thu, 24 Mar 2022 11:25:45 +0000 (11:25 +0000)
unreachable() doesn't lead to executing the code that follows it,
neither in debug nor release builds. So falling through doesn't make any
sense.

This fixes a compile-error on clang.

Let's move the default-block to the end to make it clearer that there's
no intended fallthrough.

Reviewed-by: Frank Binns <frank.binns@imgtec.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/15531>

src/imagination/include/hwdef/rogue_hw_utils.h

index fc1e4e6..39e3bea 100644 (file)
@@ -75,9 +75,6 @@ rogue_get_isp_samples_per_tile_xy(const struct pvr_device_info *dev_info,
    *y_out = tile_size_y;
 
    switch (samples) {
-   default:
-      assert(!"Unsupported number of samples");
-      FALLTHROUGH;
    case 1:
       break;
    case 2:
@@ -96,6 +93,8 @@ rogue_get_isp_samples_per_tile_xy(const struct pvr_device_info *dev_info,
    case 8:
       *y_out *= 2;
       break;
+   default:
+      assert(!"Unsupported number of samples");
    }
 }