refactor: apply review suggestion

diff --git a/src/esplusplayer/src/esplayer.cpp b/src/esplusplayer/src/esplayer.cpp
index db00901feead552c392813fa27d1491b0d9594b6..ee4f9a377c571994aeeff023c8aba68d25fac056 100644 (file)
--- a/src/esplusplayer/src/esplayer.cpp
+++ b/src/esplusplayer/src/esplayer.cpp
@@ -1977,14 +1977,17 @@ ErrorType EsPlayer::SetFmmMode() {
   int onoff = 0;
   ErrorType ret = ErrorType::kNone;
   if (trackrenderer_->GetFmmAutoMode(&onoff) == false) {
-    return ErrorType::kInvalidState;
+    return ErrorType::kInvalidOperation;
   }
 
-  constexpr int fmm_auto_off = 0;
-  if (onoff == fmm_auto_off) ret = ErrorType::kInvalidOperation;
+  enum {
+    FMM_AUTO_OFF = 0,
+    FMM_AUTO_ON = 1,
+  };
+
+  if (onoff == FMM_AUTO_OFF) ret = ErrorType::kInvalidOperation;
 
-  constexpr std::uint32_t fmm_mode_on = 1;
-  fmm_mode_ = fmm_mode_on;
+  fmm_mode_ = FMM_AUTO_ON;
 
   if (state < EsState::kReady) return ret;
 

diff --git a/src/plusplayer-core/src/trackrendereradapter.cpp b/src/plusplayer-core/src/trackrendereradapter.cpp
index 41150b9d50213c870372683bd865c0788e1fd095..038ab6574fabdd3935dd3dd0bec8bc1de605fc33 100644 (file)
--- a/src/plusplayer-core/src/trackrendereradapter.cpp
+++ b/src/plusplayer-core/src/trackrendereradapter.cpp
@@ -773,10 +773,7 @@ bool TrackRendererAdapter::RenderVideoFrame() {
 }
 
 bool TrackRendererAdapter::GetFmmAutoMode(int* onoff) {
-  if (trackrenderer_get_fmm_auto_mode(handle_, onoff) == kFailed) {
-    return false;
-  }
-  return true;
+  return (trackrenderer_get_fmm_auto_mode(handle_, onoff) == kSuccess);
 }
 
 bool TrackRendererAdapter::SetAiFilter(void* aifilter) {