mfd: ipaq-micro: Fix error check return value of platform_get_irq()
authorLv Ruyi <lv.ruyi@zte.com.cn>
Tue, 12 Apr 2022 08:53:05 +0000 (08:53 +0000)
committerLee Jones <lee.jones@linaro.org>
Tue, 26 Apr 2022 14:12:22 +0000 (15:12 +0100)
platform_get_irq() return negative value on failure, so null check of
irq is incorrect. Fix it by comparing whether it is less than zero.

Fixes: dcc21cc09e3c ("mfd: Add driver for Atmel Microcontroller on iPaq h3xxx")
Reported-by: Zeal Robot <zealci@zte.com.cn>
Signed-off-by: Lv Ruyi <lv.ruyi@zte.com.cn>
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Signed-off-by: Lee Jones <lee.jones@linaro.org>
Link: https://lore.kernel.org/r/20220412085305.2533030-1-lv.ruyi@zte.com.cn
drivers/mfd/ipaq-micro.c

index e92eeeb..4cd5ecc 100644 (file)
@@ -403,7 +403,7 @@ static int __init micro_probe(struct platform_device *pdev)
        micro_reset_comm(micro);
 
        irq = platform_get_irq(pdev, 0);
-       if (!irq)
+       if (irq < 0)
                return -EINVAL;
        ret = devm_request_irq(&pdev->dev, irq, micro_serial_isr,
                               IRQF_SHARED, "ipaq-micro",