wil6210: use NAPI_POLL_WEIGHT for napi budget
authorJakub Kicinski <kuba@kernel.org>
Fri, 29 Apr 2022 17:46:43 +0000 (10:46 -0700)
committerKalle Valo <quic_kvalo@quicinc.com>
Mon, 2 May 2022 14:00:11 +0000 (17:00 +0300)
The comment next to WIL6210_NAPI_BUDGET says "arbitrary".
If we're picking arbitrary values let's pick the recommended
default which is NAPI_POLL_WEIGHT.

Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Kalle Valo <quic_kvalo@quicinc.com>
Link: https://lore.kernel.org/r/20220429174643.196994-4-kuba@kernel.org
drivers/net/wireless/ath/wil6210/netdev.c
drivers/net/wireless/ath/wil6210/wil6210.h

index 0913f0b..3906480 100644 (file)
@@ -457,17 +457,17 @@ int wil_if_add(struct wil6210_priv *wil)
        if (wil->use_enhanced_dma_hw) {
                netif_napi_add(&wil->napi_ndev, &wil->napi_rx,
                               wil6210_netdev_poll_rx_edma,
-                              WIL6210_NAPI_BUDGET);
+                              NAPI_POLL_WEIGHT);
                netif_tx_napi_add(&wil->napi_ndev,
                                  &wil->napi_tx, wil6210_netdev_poll_tx_edma,
-                                 WIL6210_NAPI_BUDGET);
+                                 NAPI_POLL_WEIGHT);
        } else {
                netif_napi_add(&wil->napi_ndev, &wil->napi_rx,
                               wil6210_netdev_poll_rx,
-                              WIL6210_NAPI_BUDGET);
+                              NAPI_POLL_WEIGHT);
                netif_tx_napi_add(&wil->napi_ndev,
                                  &wil->napi_tx, wil6210_netdev_poll_tx,
-                                 WIL6210_NAPI_BUDGET);
+                                 NAPI_POLL_WEIGHT);
        }
 
        wil_update_net_queues_bh(wil, vif, NULL, true);
index 11946ec..22a6eb3 100644 (file)
@@ -82,7 +82,6 @@ static inline u32 WIL_GET_BITS(u32 x, int b0, int b1)
 #define WIL6210_MAX_TX_RINGS   (24) /* HW limit */
 #define WIL6210_MAX_CID                (20) /* max number of stations */
 #define WIL6210_RX_DESC_MAX_CID        (8)  /* HW limit */
-#define WIL6210_NAPI_BUDGET    (16) /* arbitrary */
 #define WIL_MAX_AMPDU_SIZE     (64 * 1024) /* FW/HW limit */
 #define WIL_MAX_AGG_WSIZE      (32) /* FW/HW limit */
 #define WIL_MAX_AMPDU_SIZE_128 (128 * 1024) /* FW/HW limit */