target-arm: Reinsert missing return statement in ARM mode SRS decode
authorPeter Chubb <peter.chubb@nicta.com.au>
Fri, 19 Apr 2013 11:24:18 +0000 (12:24 +0100)
committerPeter Maydell <peter.maydell@linaro.org>
Fri, 19 Apr 2013 11:24:18 +0000 (12:24 +0100)
Since patch
   81465888c5306cd94abb9847e560796fd13d3c2f
   target-arm: factor out handling of SRS instruction
the ARM mode SRS instruction has not worked in QEMU.

The problem is a missing return directive that was removed in the
refactoring, so after decoding the instruction, qemu would fall through
to generate an UNDEF exception for an illegal instruction.

Signed-off-by: Peter Chubb <peter.chubb@nicta.com.au>
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
target-arm/translate.c

index 35a21be..a1b7b8c 100644 (file)
@@ -6762,6 +6762,7 @@ static void disas_arm_insn(CPUARMState * env, DisasContext *s)
             }
             ARCH(6);
             gen_srs(s, (insn & 0x1f), (insn >> 23) & 3, insn & (1 << 21));
+            return;
         } else if ((insn & 0x0e50ffe0) == 0x08100a00) {
             /* rfe */
             int32_t offset;