spi: amd: Remove unneeded variable
authorLucas Tanure <tanureal@opensource.cirrus.com>
Fri, 10 Sep 2021 11:15:28 +0000 (12:15 +0100)
committerMark Brown <broonie@kernel.org>
Mon, 13 Sep 2021 01:00:31 +0000 (02:00 +0100)
Remove internal cs from amd_spi

Signed-off-by: Lucas Tanure <tanureal@opensource.cirrus.com>
Reviewed-by: Charles Keepax <ckeepax@opensource.cirrus.com>
Link: https://lore.kernel.org/r/20210910111529.12539-3-tanureal@opensource.cirrus.com
Signed-off-by: Mark Brown <broonie@kernel.org>
drivers/spi/spi-amd.c

index f2dd8d4..97838b5 100644 (file)
@@ -38,7 +38,6 @@ struct amd_spi {
        void __iomem *io_remap_addr;
        unsigned long io_base_addr;
        u32 rom_addr;
-       u8 chip_select;
 };
 
 static inline u8 amd_spi_readreg8(struct amd_spi *amd_spi, int idx)
@@ -77,10 +76,9 @@ static inline void amd_spi_setclear_reg32(struct amd_spi *amd_spi, int idx, u32
        amd_spi_writereg32(amd_spi, idx, tmp);
 }
 
-static void amd_spi_select_chip(struct amd_spi *amd_spi)
+static void amd_spi_select_chip(struct amd_spi *amd_spi, u8 cs)
 {
-       amd_spi_setclear_reg8(amd_spi, AMD_SPI_ALT_CS_REG, amd_spi->chip_select,
-                             AMD_SPI_ALT_CS_MASK);
+       amd_spi_setclear_reg8(amd_spi, AMD_SPI_ALT_CS_REG, cs, AMD_SPI_ALT_CS_MASK);
 }
 
 static void amd_spi_clear_fifo_ptr(struct amd_spi *amd_spi)
@@ -201,8 +199,7 @@ static int amd_spi_master_transfer(struct spi_master *master,
        struct amd_spi *amd_spi = spi_master_get_devdata(master);
        struct spi_device *spi = msg->spi;
 
-       amd_spi->chip_select = spi->chip_select;
-       amd_spi_select_chip(amd_spi);
+       amd_spi_select_chip(amd_spi, spi->chip_select);
 
        /*
         * Extract spi_transfers from the spi message and