RDMA/core: Create and destroy counters in the ib_core

Move allocation and destruction of counters under ib_core responsibility

Link: https://lore.kernel.org/r/20200630101855.368895-2-leon@kernel.org
Signed-off-by: Leon Romanovsky <leonro@mellanox.com>
Signed-off-by: Jason Gunthorpe <jgg@nvidia.com>

diff --git a/drivers/infiniband/core/device.c b/drivers/infiniband/core/device.c
index 1900c0df3c8a975e9e09b3a951cd6169925a14b2..0a259f475e898d5952e2b3cb7c9f9094d13917a0 100644 (file)
--- a/drivers/infiniband/core/device.c
+++ b/drivers/infiniband/core/device.c
@@ -2687,6 +2687,7 @@ void ib_set_device_ops(struct ib_device *dev, const struct ib_device_ops *ops)
        SET_DEVICE_OP(dev_ops, set_vf_link_state);
 
        SET_OBJ_SIZE(dev_ops, ib_ah);
+       SET_OBJ_SIZE(dev_ops, ib_counters);
        SET_OBJ_SIZE(dev_ops, ib_cq);
        SET_OBJ_SIZE(dev_ops, ib_pd);
        SET_OBJ_SIZE(dev_ops, ib_srq);

diff --git a/drivers/infiniband/core/uverbs_std_types_counters.c b/drivers/infiniband/core/uverbs_std_types_counters.c
index 9f013304e67786550bb8307caaf4df469758b86b..c7e7438752bc3e5f174c38d6d6e216e4e223a538 100644 (file)
--- a/drivers/infiniband/core/uverbs_std_types_counters.c
+++ b/drivers/infiniband/core/uverbs_std_types_counters.c
@@ -46,7 +46,9 @@ static int uverbs_free_counters(struct ib_uobject *uobject,
        if (ret)
                return ret;
 
-       return counters->device->ops.destroy_counters(counters);
+       counters->device->ops.destroy_counters(counters);
+       kfree(counters);
+       return 0;
 }
 
 static int UVERBS_HANDLER(UVERBS_METHOD_COUNTERS_CREATE)(
@@ -66,20 +68,19 @@ static int UVERBS_HANDLER(UVERBS_METHOD_COUNTERS_CREATE)(
        if (!ib_dev->ops.create_counters)
                return -EOPNOTSUPP;
 
-       counters = ib_dev->ops.create_counters(ib_dev, attrs);
-       if (IS_ERR(counters)) {
-               ret = PTR_ERR(counters);
-               goto err_create_counters;
-       }
+       counters = rdma_zalloc_drv_obj(ib_dev, ib_counters);
+       if (!counters)
+               return -ENOMEM;
 
        counters->device = ib_dev;
        counters->uobject = uobj;
        uobj->object = counters;
        atomic_set(&counters->usecnt, 0);
 
-       return 0;
+       ret = ib_dev->ops.create_counters(counters, attrs);
+       if (ret)
+               kfree(counters);
 
-err_create_counters:
        return ret;
 }
 

diff --git a/drivers/infiniband/hw/mlx5/main.c b/drivers/infiniband/hw/mlx5/main.c
index 324a98c77ad5273fc0eb412b442a24154c2a3fef..6e6e126c39efbc1d6b2fa96c054a4fdef5150689 100644 (file)
--- a/drivers/infiniband/hw/mlx5/main.c
+++ b/drivers/infiniband/hw/mlx5/main.c
@@ -6455,7 +6455,7 @@ err_bound:
        return ret;
 }
 
-static int mlx5_ib_destroy_counters(struct ib_counters *counters)
+static void mlx5_ib_destroy_counters(struct ib_counters *counters)
 {
        struct mlx5_ib_mcounters *mcounters = to_mcounters(counters);
 
@@ -6463,24 +6463,15 @@ static int mlx5_ib_destroy_counters(struct ib_counters *counters)
        if (mcounters->hw_cntrs_hndl)
                mlx5_fc_destroy(to_mdev(counters->device)->mdev,
                                mcounters->hw_cntrs_hndl);
-
-       kfree(mcounters);
-
-       return 0;
 }
 
-static struct ib_counters *mlx5_ib_create_counters(struct ib_device *device,
-                                                  struct uverbs_attr_bundle *attrs)
+static int mlx5_ib_create_counters(struct ib_counters *counters,
+                                  struct uverbs_attr_bundle *attrs)
 {
-       struct mlx5_ib_mcounters *mcounters;
-
-       mcounters = kzalloc(sizeof(*mcounters), GFP_KERNEL);
-       if (!mcounters)
-               return ERR_PTR(-ENOMEM);
+       struct mlx5_ib_mcounters *mcounters = to_mcounters(counters);
 
        mutex_init(&mcounters->mcntrs_mutex);
-
-       return &mcounters->ibcntrs;
+       return 0;
 }
 
 static void mlx5_ib_stage_init_cleanup(struct mlx5_ib_dev *dev)
@@ -6648,6 +6639,7 @@ static const struct ib_device_ops mlx5_ib_dev_ops = {
        .resize_cq = mlx5_ib_resize_cq,
 
        INIT_RDMA_OBJ_SIZE(ib_ah, mlx5_ib_ah, ibah),
+       INIT_RDMA_OBJ_SIZE(ib_counters, mlx5_ib_mcounters, ibcntrs),
        INIT_RDMA_OBJ_SIZE(ib_cq, mlx5_ib_cq, ibcq),
        INIT_RDMA_OBJ_SIZE(ib_pd, mlx5_ib_pd, ibpd),
        INIT_RDMA_OBJ_SIZE(ib_srq, mlx5_ib_srq, ibsrq),

diff --git a/include/rdma/ib_verbs.h b/include/rdma/ib_verbs.h
index 6c72bb194148784105c4f1a9c2fc694b845752c9..ecaf299e0789f5d9878890e0256be510649a36d9 100644 (file)
--- a/include/rdma/ib_verbs.h
+++ b/include/rdma/ib_verbs.h
@@ -2540,9 +2540,9 @@ struct ib_device_ops {
        struct ib_mr *(*reg_dm_mr)(struct ib_pd *pd, struct ib_dm *dm,
                                   struct ib_dm_mr_attr *attr,
                                   struct uverbs_attr_bundle *attrs);
-       struct ib_counters *(*create_counters)(
-               struct ib_device *device, struct uverbs_attr_bundle *attrs);
-       int (*destroy_counters)(struct ib_counters *counters);
+       int (*create_counters)(struct ib_counters *counters,
+                              struct uverbs_attr_bundle *attrs);
+       void (*destroy_counters)(struct ib_counters *counters);
        int (*read_counters)(struct ib_counters *counters,
                             struct ib_counters_read_attr *counters_read_attr,
                             struct uverbs_attr_bundle *attrs);
@@ -2650,6 +2650,7 @@ struct ib_device_ops {
                              struct uverbs_attr_bundle *attrs);
 
        DECLARE_RDMA_OBJ_SIZE(ib_ah);
+       DECLARE_RDMA_OBJ_SIZE(ib_counters);
        DECLARE_RDMA_OBJ_SIZE(ib_cq);
        DECLARE_RDMA_OBJ_SIZE(ib_pd);
        DECLARE_RDMA_OBJ_SIZE(ib_srq);