net: korina: fix kfree of rx/tx descriptor array
authorValentin Vidic <vvidic@valentin-vidic.from.hr>
Sun, 11 Oct 2020 22:03:29 +0000 (00:03 +0200)
committerJakub Kicinski <kuba@kernel.org>
Mon, 12 Oct 2020 17:05:48 +0000 (10:05 -0700)
kmalloc returns KSEG0 addresses so convert back from KSEG1
in kfree. Also make sure array is freed when the driver is
unloaded from the kernel.

Fixes: ef11291bcd5f ("Add support the Korina (IDT RC32434) Ethernet MAC")
Signed-off-by: Valentin Vidic <vvidic@valentin-vidic.from.hr>
Acked-by: Willem de Bruijn <willemb@google.com>
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/korina.c

index 03e0349..af441d6 100644 (file)
@@ -1113,7 +1113,7 @@ out:
        return rc;
 
 probe_err_register:
-       kfree(lp->td_ring);
+       kfree(KSEG0ADDR(lp->td_ring));
 probe_err_td_ring:
        iounmap(lp->tx_dma_regs);
 probe_err_dma_tx:
@@ -1133,6 +1133,7 @@ static int korina_remove(struct platform_device *pdev)
        iounmap(lp->eth_regs);
        iounmap(lp->rx_dma_regs);
        iounmap(lp->tx_dma_regs);
+       kfree(KSEG0ADDR(lp->td_ring));
 
        unregister_netdev(bif->dev);
        free_netdev(bif->dev);