blk-iolatency: only account submitted bios
authorDennis Zhou <dennis@kernel.org>
Thu, 23 May 2019 20:10:18 +0000 (16:10 -0400)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 26 Jul 2019 07:14:09 +0000 (09:14 +0200)
[ Upstream commit a3fb01ba5af066521f3f3421839e501bb2c71805 ]

As is, iolatency recognizes done_bio and cleanup as ending paths. If a
request is marked REQ_NOWAIT and fails to get a request, the bio is
cleaned up via rq_qos_cleanup() and ended in bio_wouldblock_error().
This results in underflowing the inflight counter. Fix this by only
accounting bios that were actually submitted.

Signed-off-by: Dennis Zhou <dennis@kernel.org>
Cc: Josef Bacik <josef@toxicpanda.com>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Signed-off-by: Sasha Levin <sashal@kernel.org>
block/blk-iolatency.c

index 6b8396c..75df47a 100644 (file)
@@ -565,6 +565,10 @@ static void blkcg_iolatency_done_bio(struct rq_qos *rqos, struct bio *bio)
        if (!blkg)
                return;
 
+       /* We didn't actually submit this bio, don't account it. */
+       if (bio->bi_status == BLK_STS_AGAIN)
+               return;
+
        iolat = blkg_to_lat(bio->bi_blkg);
        if (!iolat)
                return;