projects
/
platform
/
kernel
/
linux-rpi.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
21ccc58
)
thermal/drivers/imx_sc_thermal: Fix refcount leak in imx_sc_thermal_probe
author
Miaoqian Lin
<linmq006@gmail.com>
Tue, 17 May 2022 05:51:21 +0000
(09:51 +0400)
committer
Greg Kroah-Hartman
<gregkh@linuxfoundation.org>
Thu, 9 Jun 2022 08:23:01 +0000
(10:23 +0200)
[ Upstream commit
09700c504d8e63faffd2a2235074e8c5d130cb8f
]
of_find_node_by_name() returns a node pointer with refcount
incremented, we should use of_node_put() on it when done.
Add missing of_node_put() to avoid refcount leak.
Fixes:
e20db70dba1c
("thermal: imx_sc: add i.MX system controller thermal support")
Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
Link:
https://lore.kernel.org/r/20220517055121.18092-1-linmq006@gmail.com
Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/thermal/imx_sc_thermal.c
patch
|
blob
|
history
diff --git
a/drivers/thermal/imx_sc_thermal.c
b/drivers/thermal/imx_sc_thermal.c
index
8d76dbf
..
331a241
100644
(file)
--- a/
drivers/thermal/imx_sc_thermal.c
+++ b/
drivers/thermal/imx_sc_thermal.c
@@
-94,8
+94,8
@@
static int imx_sc_thermal_probe(struct platform_device *pdev)
sensor = devm_kzalloc(&pdev->dev, sizeof(*sensor), GFP_KERNEL);
if (!sensor) {
of_node_put(child);
-
of_node_put(sensor_np)
;
-
return -ENOMEM
;
+
ret = -ENOMEM
;
+
goto put_node
;
}
ret = thermal_zone_of_get_sensor_id(child,
@@
-124,7
+124,9
@@
static int imx_sc_thermal_probe(struct platform_device *pdev)
dev_warn(&pdev->dev, "failed to add hwmon sysfs attributes\n");
}
+put_node:
of_node_put(sensor_np);
+ of_node_put(np);
return ret;
}