gst/gstpreset.c: Add some comments and TODOs.

Original commit message from CVS:
* gst/gstpreset.c:
Add some comments and TODOs.
* gst/gstpreset.h:
Add padding for future changes.
* plugins/elements/gstqueue.c:
Implement the iface.

diff --git a/ChangeLog b/ChangeLog
index 7ff4bb6609272d3e980bfb025ba8b21fdfc7fed6..699cfc590e2d396e0b20b6e7245e9caea8b1bbb0 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,14 @@
+2007-11-17  Stefan Kost  <ensonic@users.sf.net>
+
+       * gst/gstpreset.c:
+         Add some comments and TODOs.
+
+       * gst/gstpreset.h:
+         Add padding for future changes.
+
+       * plugins/elements/gstqueue.c:
+         Implement the iface.    
+
 2007-11-17  Stefan Kost  <ensonic@users.sf.net>
 
        * docs/gst/gstreamer-docs.sgml:

diff --git a/gst/gstpreset.c b/gst/gstpreset.c
index 6ac1bad0f3c48c27efb6e6e8b056263844524a8f..d4993e4eb1188868675961effdf34df2affce124 100644 (file)
--- a/gst/gstpreset.c
+++ b/gst/gstpreset.c
@@ -36,6 +36,7 @@
  * - how can we support both Preferences and Presets, a flag for _get_preset_names ?
  * - should there be a 'preset-list' property to get the preset list
  *   (and to connect a notify:: to to listen for changes)
+ * - do we want to ship presets for some elements?
  *
  * http://www.buzztard.org/index.php/Preset_handling_interface
  */

diff --git a/gst/gstpreset.h b/gst/gstpreset.h
index fab9babd7186d331da3b3a1a0c0440f3f0a32324..08e96113ea1437298ee1f878b645a6a03c0f2e29 100644 (file)
--- a/gst/gstpreset.h
+++ b/gst/gstpreset.h
@@ -61,6 +61,9 @@ struct _GstPresetInterface
    * instances of a type and if the list changes, we trigger the signal for all
    * instance
    */
+
+  /*< private >*/
+  gpointer _gst_reserved[GST_PADDING];
 };
 
 GType gst_preset_get_type(void);

diff --git a/plugins/elements/gstqueue.c b/plugins/elements/gstqueue.c
index 5b160688a7846f7fde4ea8aee535fc4f4e787d91..579d7fcc3b9448462eb8f750d9b939bed7be9826 100644 (file)
--- a/plugins/elements/gstqueue.c
+++ b/plugins/elements/gstqueue.c
@@ -174,7 +174,15 @@ enum
 #define _do_init(bla) \
     GST_DEBUG_CATEGORY_INIT (queue_debug, "queue", 0, "queue element"); \
     GST_DEBUG_CATEGORY_INIT (queue_dataflow, "queue_dataflow", 0, \
-        "dataflow inside the queue element");
+        "dataflow inside the queue element"); \
+    { \
+      const GInterfaceInfo preset_interface_info = { \
+        NULL,               /* interface_init */ \
+        NULL,               /* interface_finalize */ \
+        NULL                /* interface_data */ \
+      }; \
+      g_type_add_interface_static(object_type, GST_TYPE_PRESET, &preset_interface_info); \
+   }
 
 GST_BOILERPLATE_FULL (GstQueue, gst_queue, GstElement,
     GST_TYPE_ELEMENT, _do_init);