Avoid calling FocusRing Hide when already it is hidden state.
authorManish R Gurnaney <m.gurnaney@samsung.com>
Wed, 23 Oct 2013 10:18:19 +0000 (15:48 +0530)
committerGerrit Code Review <gerrit@gerrit.vlan144.tizendev.org>
Thu, 24 Oct 2013 01:34:20 +0000 (01:34 +0000)
    [Version] common
    [Title] FocusRing doesn't come when tap on edit fields.
    [BinType] N/A
    [Customer] HQ
    [Issue#] WEB-3912
    [Problem] FocusRing doesn't come when tap on edit fields.
    [Cause] Contents are getting changed continueously which indirectly calls
            didChangeFocusedRect and it calls hide when already FocusRing state
            is hidden. This will clear showtimer which is set on tap event.
    [Solution] Before calling FocusRing hide we should check whether the state of
            FocusRing is hidden or not. If it is hidden State then don't call Hide.
    [Team] WebCoreSupport
    [Developer] m.gurnaney@samsung.com
    [Request] N/A
    [Horizontal expansion] N/A
    [SCMRequest] NA

    Change-Id: Id2bc3dbcf314bc58bb75d9c586989c680200d0ba

Change-Id: I924c019ace09bc11e24a3742277cbe5e2c15e4d6

Source/WebKit2/UIProcess/efl/WebPageProxyEfl.cpp

index ff397ec..d9ca56f 100755 (executable)
@@ -1110,7 +1110,7 @@ void WebPageProxy::didChangeFocusedRects(const Vector<IntRect>& rects)
 
         if (canUpdate)
             focusRing->show(rects);
-    } else
+    } else if (focusRing->canUpdate())
         focusRing->hide(false);
 }