staging: rtl8723bs: Using comparison to true is error prone
authorJohn Oldman <john.oldman@polehill.co.uk>
Fri, 15 May 2020 17:31:08 +0000 (18:31 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 19 May 2020 14:13:40 +0000 (16:13 +0200)
fix below issue reported by checkpatch

CHECK: Using comparison to true is error prone
CHECK: Using comparison to false is error prone

Signed-off-by: John Oldman <john.oldman@polehill.co.uk>
Link: https://lore.kernel.org/r/20200515173108.14739-1-john.oldman@polehill.co.uk
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/rtl8723bs/core/rtw_security.c

index 5ebf691..0f95009 100644 (file)
@@ -756,7 +756,7 @@ u32 rtw_tkip_decrypt(struct adapter *padapter, u8 *precvframe)
                                static u32 no_gkey_bc_cnt;
                                static u32 no_gkey_mc_cnt;
 
-                               if (psecuritypriv->binstallGrpkey == false) {
+                               if (!psecuritypriv->binstallGrpkey) {
                                        res = _FAIL;
 
                                        if (start == 0)
@@ -1837,7 +1837,7 @@ u32 rtw_aes_decrypt(struct adapter *padapter, u8 *precvframe)
                                static u32 no_gkey_bc_cnt;
                                static u32 no_gkey_mc_cnt;
 
-                               if (psecuritypriv->binstallGrpkey == false) {
+                               if (!psecuritypriv->binstallGrpkey) {
                                        res = _FAIL;
 
                                        if (start == 0)
@@ -2369,7 +2369,7 @@ u8 rtw_handle_tkip_countermeasure(struct adapter *adapter, const char *caller)
        struct security_priv *securitypriv = &(adapter->securitypriv);
        u8 status = _SUCCESS;
 
-       if (securitypriv->btkip_countermeasure == true) {
+       if (securitypriv->btkip_countermeasure) {
                unsigned long passing_ms = jiffies_to_msecs(jiffies - securitypriv->btkip_countermeasure_time);
                if (passing_ms > 60*1000) {
                        DBG_871X_LEVEL(_drv_always_, "%s("ADPT_FMT") countermeasure time:%lus > 60s\n",