terminal: Only set title if asprintf succeeded
authorBryce W. Harrington <b.harrington@samsung.com>
Tue, 14 Jan 2014 21:58:32 +0000 (21:58 +0000)
committerKristian Høgsberg <krh@bitplanet.net>
Fri, 17 Jan 2014 19:29:54 +0000 (11:29 -0800)
Handles potential out of memory situation by skipping the title update.
This fixes the following warning:

  terminal.c: In function ‘resize_handler’:
  terminal.c:851:11: warning: ignoring return value of ‘asprintf’,
  declared with attribute warn_unused_result [-Wunused-result]

Signed-off-by: Bryce Harrington <b.harrington@samsung.com>
clients/terminal.c

index e2a6236..09bc321 100644 (file)
@@ -848,9 +848,10 @@ resize_handler(struct widget *widget,
                width = columns * terminal->average_width + m;
                height = rows * terminal->extents.height + m;
                widget_set_size(terminal->widget, width, height);
-               asprintf(&p, "%s — [%dx%d]", terminal->title, columns, rows);
-               window_set_title(terminal->window, p);
-               free(p);
+               if (asprintf(&p, "%s — [%dx%d]", terminal->title, columns, rows) > 0) {
+                   window_set_title(terminal->window, p);
+                   free(p);
+               }
        }
 
        terminal_resize_cells(terminal, columns, rows);