projects
/
platform
/
upstream
/
efl.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
a800dc9
)
elm/hoversel: use a wref to accurately track internal hover object
author
Mike Blumenkrantz
<zmike@samsung.com>
Thu, 2 Apr 2020 17:57:21 +0000
(13:57 -0400)
committer
Jongmin Lee
<jm105.lee@samsung.com>
Thu, 16 Apr 2020 21:31:35 +0000
(06:31 +0900)
this pointer is never unset, which can cause errors when attempting to
access it after the hoversel has been deactivated
Differential Revision: https://phab.enlightenment.org/D11642
src/lib/elementary/elc_hoversel.c
patch
|
blob
|
history
diff --git
a/src/lib/elementary/elc_hoversel.c
b/src/lib/elementary/elc_hoversel.c
index
86f3965
..
0c67db2
100644
(file)
--- a/
src/lib/elementary/elc_hoversel.c
+++ b/
src/lib/elementary/elc_hoversel.c
@@
-528,7
+528,7
@@
_activate(Evas_Object *obj)
sd->expanded = EINA_TRUE;
-
sd->hover = elm_hover_add(sd->hover_parent
);
+
efl_wref_add(elm_hover_add(sd->hover_parent), &sd->hover
);
efl_event_callback_add(sd->hover, EFL_EVENT_KEY_DOWN, _hover_key_down, obj);
elm_widget_sub_object_add(obj, sd->hover);