drm/vram-helper: make drm_vram_mm_debugfs_init() return 0
authorWambui Karuga <wambui.karugax@gmail.com>
Tue, 10 Mar 2020 13:31:14 +0000 (16:31 +0300)
committerDaniel Vetter <daniel.vetter@ffwll.ch>
Wed, 18 Mar 2020 15:24:48 +0000 (16:24 +0100)
Since 987d65d01356 (drm: debugfs: make
drm_debugfs_create_files() never fail), drm_debugfs_create_files() never
fails and should return void. Therefore, remove its use as the
return value of drm_vram_mm_debugfs_init(), and have the function
return 0 directly.

v2: have drm_vram_mm_debugfs_init() return 0 instead of void to avoid
introducing build issues and build breakage.

References: https://lists.freedesktop.org/archives/dri-devel/2020-February/257183.html
Signed-off-by: Wambui Karuga <wambui.karugax@gmail.com>
Acked-by: Thomas Zimmermann <tzimmermann@suse.de>
Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Link: https://patchwork.freedesktop.org/patch/msgid/20200310133121.27913-11-wambui.karugax@gmail.com
drivers/gpu/drm/drm_gem_vram_helper.c

index 92a11bb..c8bcc86 100644 (file)
@@ -1048,14 +1048,12 @@ static const struct drm_info_list drm_vram_mm_debugfs_list[] = {
  */
 int drm_vram_mm_debugfs_init(struct drm_minor *minor)
 {
-       int ret = 0;
-
 #if defined(CONFIG_DEBUG_FS)
-       ret = drm_debugfs_create_files(drm_vram_mm_debugfs_list,
-                                      ARRAY_SIZE(drm_vram_mm_debugfs_list),
-                                      minor->debugfs_root, minor);
+       drm_debugfs_create_files(drm_vram_mm_debugfs_list,
+                                ARRAY_SIZE(drm_vram_mm_debugfs_list),
+                                minor->debugfs_root, minor);
 #endif
-       return ret;
+       return 0;
 }
 EXPORT_SYMBOL(drm_vram_mm_debugfs_init);