power: reset: gemini-poweroff: Fix IRQ check in gemini_poweroff_probe
authorMiaoqian Lin <linmq006@gmail.com>
Thu, 20 Jan 2022 10:46:54 +0000 (10:46 +0000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 8 Apr 2022 12:23:27 +0000 (14:23 +0200)
[ Upstream commit ba18dad0fb880cd29aa97b6b75560ef14d1061ba ]

platform_get_irq() returns negative error number instead 0 on failure.
And the doc of platform_get_irq() provides a usage example:

    int irq = platform_get_irq(pdev, 0);
    if (irq < 0)
        return irq;

Fix the check of return value to catch errors correctly.

Fixes: f7a388d6cd1c ("power: reset: Add a driver for the Gemini poweroff")
Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/power/reset/gemini-poweroff.c

index 90e35c0..b7f7a82 100644 (file)
@@ -107,8 +107,8 @@ static int gemini_poweroff_probe(struct platform_device *pdev)
                return PTR_ERR(gpw->base);
 
        irq = platform_get_irq(pdev, 0);
-       if (!irq)
-               return -EINVAL;
+       if (irq < 0)
+               return irq;
 
        gpw->dev = dev;