tbm_surface_internal: Fix insecure strncmp 58/317858/1
authorChangyeon Lee <cyeon.lee@samsung.com>
Thu, 19 Sep 2024 10:34:32 +0000 (19:34 +0900)
committerChangyeon Lee <cyeon.lee@samsung.com>
Thu, 19 Sep 2024 10:35:27 +0000 (19:35 +0900)
Change-Id: I6fb7dfdfe017f421459a1814a1b1cb2756dc6a7d

src/tbm_surface_internal.c

index c1024c58a488161155cde03fa7034a88788d4ef1..7b70470575160286b24ae9e53e806fd013f5f7b4 100644 (file)
@@ -1733,7 +1733,7 @@ _tbm_surface_internal_debug_data_value_update(tbm_surface_debug_data *debug_data
        if (!debug_data->value && !value)
                return;
 
-       if (debug_data->value && value && !strncmp(debug_data->value, value, strlen(debug_data->value)))
+       if (debug_data->value && value && !strncmp(debug_data->value, value, strlen(debug_data->value) + 1))
                return;
 
        if (debug_data->value)
@@ -1754,7 +1754,7 @@ _tbm_surface_internal_debug_data_find(struct list_head *list, char *key)
                return NULL;
 
        LIST_FOR_EACH_ENTRY(debug_data, list, item_link) {
-               if (!strncmp(debug_data->key, key, strlen(debug_data->key)))
+               if (!strncmp(debug_data->key, key, strlen(debug_data->key) + 1))
                        return debug_data;
        }