drm/vmwgfx: Don't send drm sysfs hotplug events on initial master set
authorThomas Hellstrom <thellstrom@vmware.com>
Tue, 7 May 2019 09:07:53 +0000 (11:07 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sun, 9 Jun 2019 07:17:22 +0000 (09:17 +0200)
commit 63cb44441826e842b7285575b96db631cc9f2505 upstream.

This may confuse user-space clients like plymouth that opens a drm
file descriptor as a result of a hotplug event and then generates a
new event...

Cc: <stable@vger.kernel.org>
Fixes: 5ea1734827bb ("drm/vmwgfx: Send a hotplug event at master_set")
Signed-off-by: Thomas Hellstrom <thellstrom@vmware.com>
Reviewed-by: Deepak Rawat <drawat@vmware.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/gpu/drm/vmwgfx/vmwgfx_drv.c

index c72b942f2bdffe9f5e48004f0bf9810aba5bb041..82ae687166968a546275681e5efd6808d17abce5 100644 (file)
@@ -1291,7 +1291,13 @@ static int vmw_master_set(struct drm_device *dev,
        }
 
        dev_priv->active_master = vmaster;
-       drm_sysfs_hotplug_event(dev);
+
+       /*
+        * Inform a new master that the layout may have changed while
+        * it was gone.
+        */
+       if (!from_open)
+               drm_sysfs_hotplug_event(dev);
 
        return 0;
 }