This enables the general linter checking for "build/c++11" violations
during presubmit and instead marks the few known exceptions that we
allow explicitly.
R=jochen@chromium.org
Review URL: https://codereview.chromium.org/
1317463007
Cr-Commit-Position: refs/heads/master@{#30621}
/**
* Move constructor.
*/
- V8_INLINE Global(Global&& other) : PersistentBase<T>(other.val_) {
+ V8_INLINE Global(Global&& other) : PersistentBase<T>(other.val_) { // NOLINT
other.val_ = nullptr;
}
V8_INLINE ~Global() { this->Reset(); }
* Move via assignment.
*/
template <class S>
- V8_INLINE Global& operator=(Global<S>&& rhs) {
+ V8_INLINE Global& operator=(Global<S>&& rhs) { // NOLINT
TYPE_CHECK(T, S);
if (this != &rhs) {
this->Reset();
/**
* Pass allows returning uniques from functions, etc.
*/
- Global Pass() { return static_cast<Global&&>(*this); }
+ Global Pass() { return static_cast<Global&&>(*this); } // NOLINT
/*
* For compatibility with Chromium's base::Bind (base::Passed).
#include "src/codegen.h"
#if defined(V8_OS_AIX)
-#include <fenv.h>
+#include <fenv.h> // NOLINT(build/c++11)
#endif
#include "src/bootstrapper.h"
#include "src/compiler.h"
# TODO(mstarzinger): Fix and re-enable readability/namespace
LINT_RULES = """
--build/c++11
-build/header_guard
+build/include_alpha
-build/include_what_you_use