usb: chipidea: ci_hdrc_imx: use dev_err_probe
authorAlexander Stein <alexander.stein@ew.tq-group.com>
Mon, 30 Jan 2023 09:41:51 +0000 (10:41 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 31 Jan 2023 09:39:59 +0000 (10:39 +0100)
Add error message if finding USB PHY fails or is deferred.

Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
Link: https://lore.kernel.org/r/20230130094151.95174-1-alexander.stein@ew.tq-group.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/chipidea/ci_hdrc_imx.c

index 0dc4825..2eeccf4 100644 (file)
@@ -413,15 +413,19 @@ static int ci_hdrc_imx_probe(struct platform_device *pdev)
        data->phy = devm_usb_get_phy_by_phandle(dev, "fsl,usbphy", 0);
        if (IS_ERR(data->phy)) {
                ret = PTR_ERR(data->phy);
-               if (ret != -ENODEV)
+               if (ret != -ENODEV) {
+                       dev_err_probe(dev, ret, "Failed to parse fsl,usbphy\n");
                        goto err_clk;
+               }
                data->phy = devm_usb_get_phy_by_phandle(dev, "phys", 0);
                if (IS_ERR(data->phy)) {
                        ret = PTR_ERR(data->phy);
-                       if (ret == -ENODEV)
+                       if (ret == -ENODEV) {
                                data->phy = NULL;
-                       else
+                       } else {
+                               dev_err_probe(dev, ret, "Failed to parse phys\n");
                                goto err_clk;
+                       }
                }
        }