Fix warnings

Change-Id: Ia02005a79d8b32c23066c0114f2b4eac0f106239
Signed-off-by: pjh9216 <jh9216.park@samsung.com>

diff --git a/src/rust-tizen-bundle/src/tests/tizen_bundle_tests.rs b/src/rust-tizen-bundle/src/tests/tizen_bundle_tests.rs
index 8d06b2849889d434f1fcb212e8447dde1142aa90..bda005f9d149d21a8fbc8a0e50815e1d5bb8cba8 100644 (file)
--- a/src/rust-tizen-bundle/src/tests/tizen_bundle_tests.rs
+++ b/src/rust-tizen-bundle/src/tests/tizen_bundle_tests.rs
@@ -1,7 +1,4 @@
-use tizen_bundle;
-
-#[warn(unused_imports)]
-use tizen_bundle::{Bundle, BundleError, BundleType, BundleIter, BundleValue};
+use tizen_bundle::{Bundle, BundleError, BundleType, BundleValue};
 
 #[test]
 fn test_bundle_new_and_get_raw_handle() {
@@ -66,7 +63,7 @@ fn test_bundle_clone() {
     let mut b = Bundle::new();
     b.add_str("key1", "value1").unwrap();
     b.add_str_vec("key2", &["value1", "value2"]).unwrap();
-    let mut cloned_b = b.clone();
+    let cloned_b = b.clone();
     assert_eq!(b.get_str("key1").unwrap(), cloned_b.get_str("key1").unwrap());
     assert_eq!(b.get_str_vec("key2").unwrap(), cloned_b.get_str_vec("key2").unwrap());
 }
@@ -85,7 +82,7 @@ fn test_bundle_delete() {
     assert_eq!(b.get_str("key1").unwrap(), "value1");
     b.delete("key1").unwrap();
     let ret = b.get_str("key1");
-    match (ret) {
+    match ret {
       Err(err) => assert_eq!(err, BundleError::KeyNotAvailable),
       _ => panic!("Unexpected error"),
     };
@@ -117,7 +114,6 @@ fn test_bundle_iter() {
                 assert_eq!(key, "key4");
                 assert_eq!(value, &[&[1, 2, 3], &[4, 5, 6]]);
             }
-            _ => assert!(false),
         }
     }
 }
@@ -148,7 +144,6 @@ fn test_bundle_into_iter() {
                 assert_eq!(key, "key4");
                 assert_eq!(value, &[&[1, 2, 3], &[4, 5, 6]]);
             }
-            _ => assert!(false),
         }
     }
 }
@@ -157,8 +152,8 @@ fn test_bundle_into_iter() {
 fn test_bundle_encode_and_decode() {
     let mut b = Bundle::new();
     b.add_str("key1", "value1").unwrap();
-    let mut encoded_str = b.encode().unwrap();
-    let mut decoded_b = Bundle::decode(&encoded_str).unwrap();
+    let encoded_str = b.encode().unwrap();
+    let decoded_b = Bundle::decode(&encoded_str).unwrap();
     assert_eq!(b.get_str("key1").unwrap(), decoded_b.get_str("key1").unwrap());
 }
 
@@ -183,7 +178,7 @@ fn test_bundle_from_raw_handle() {
     match result {
         Ok(handle) => {
             assert!(!handle.is_null());
-            let mut b2 = Bundle::from_raw_handle(handle, true);
+            let b2 = Bundle::from_raw_handle(handle, true);
             assert_eq!(b2.get_str("key1").unwrap(), "value1");
         },
         Err(err) => panic!("Failed to detach bundle. err: {:?}", err),

diff --git a/src/rust-tizen-parcel/src/tests/tizen_parcel_tests.rs b/src/rust-tizen-parcel/src/tests/tizen_parcel_tests.rs
index f172b893f6add3d6fabb77485fa4485b5f2c3617..e1f49c3918e5b8640a941208a5703fe06c76794a 100644 (file)
--- a/src/rust-tizen-parcel/src/tests/tizen_parcel_tests.rs
+++ b/src/rust-tizen-parcel/src/tests/tizen_parcel_tests.rs
@@ -1,12 +1,9 @@
-use tizen_parcel;
-
-#[warn(unused_imports)]
 use tizen_parcel::{Parcel, ParcelError};
 
 #[test]
 fn test_parcel_write_bool_and_read_bool() {
     let mut parcel = Parcel::new();
-    parcel.write_bool(true);
+    let _ = parcel.write_bool(true);
     let result = parcel.read_bool().unwrap();
     assert_eq!(result, true);
 }
@@ -14,7 +11,7 @@ fn test_parcel_write_bool_and_read_bool() {
 #[test]
 fn test_parcel_write_i8_and_read_i8() {
     let mut parcel = Parcel::new();
-    parcel.write_i8(1);
+    let _ = parcel.write_i8(1);
     let result = parcel.read_i8().unwrap();
     assert_eq!(result, 1);
 }
@@ -22,7 +19,7 @@ fn test_parcel_write_i8_and_read_i8() {
 #[test]
 fn test_parcel_write_i16_and_read_i16() {
     let mut parcel = Parcel::new();
-    parcel.write_i16(1);
+    let _ = parcel.write_i16(1);
     let result = parcel.read_i16().unwrap();
     assert_eq!(result, 1);
 }
@@ -30,7 +27,7 @@ fn test_parcel_write_i16_and_read_i16() {
 #[test]
 fn test_parcel_write_i32_and_read_i32() {
     let mut parcel = Parcel::new();
-    parcel.write_i32(1);
+    let _ = parcel.write_i32(1);
     let result = parcel.read_i32().unwrap();
     assert_eq!(result, 1);
 }
@@ -38,7 +35,7 @@ fn test_parcel_write_i32_and_read_i32() {
 #[test]
 fn test_parcel_write_i64_and_read_i64() {
     let mut parcel = Parcel::new();
-    parcel.write_i64(1);
+    let _ = parcel.write_i64(1);
     let result = parcel.read_i64().unwrap();
     assert_eq!(result, 1);
 }
@@ -46,7 +43,7 @@ fn test_parcel_write_i64_and_read_i64() {
 #[test]
 fn test_parcel_write_u16_and_read_u16() {
     let mut parcel = Parcel::new();
-    parcel.write_u16(1);
+    let _ = parcel.write_u16(1);
     let result = parcel.read_u16().unwrap();
     assert_eq!(result, 1);
 }
@@ -54,7 +51,7 @@ fn test_parcel_write_u16_and_read_u16() {
 #[test]
 fn test_parcel_write_u32_and_read_u32() {
     let mut parcel = Parcel::new();
-    parcel.write_u32(1);
+    let _ = parcel.write_u32(1);
     let result = parcel.read_u32().unwrap();
     assert_eq!(result, 1);
 }
@@ -62,7 +59,7 @@ fn test_parcel_write_u32_and_read_u32() {
 #[test]
 fn test_parcel_write_u64_and_read_u64() {
     let mut parcel = Parcel::new();
-    parcel.write_u64(1);
+    let _ = parcel.write_u64(1);
     let result = parcel.read_u64().unwrap();
     assert_eq!(result, 1);
 }
@@ -70,7 +67,7 @@ fn test_parcel_write_u64_and_read_u64() {
 #[test]
 fn test_parcel_write_f32_and_read_f32() {
     let mut parcel = Parcel::new();
-    parcel.write_f32(1.0);
+    let _ = parcel.write_f32(1.0);
     let result = parcel.read_f32().unwrap();
     assert_eq!(result, 1.0);
 }
@@ -78,7 +75,7 @@ fn test_parcel_write_f32_and_read_f32() {
 #[test]
 fn test_parcel_write_f64_and_read_f64() {
     let mut parcel = Parcel::new();
-    parcel.write_f64(1.0);
+    let _ = parcel.write_f64(1.0);
     let result = parcel.read_f64().unwrap();
     assert_eq!(result, 1.0);
 }
@@ -86,7 +83,7 @@ fn test_parcel_write_f64_and_read_f64() {
 #[test]
 fn test_parcel_write_string_and_read_string() {
     let mut parcel = Parcel::new();
-    parcel.write_string("test");
+    let _ = parcel.write_string("test");
     let result = parcel.read_string().unwrap();
     assert_eq!(result, "test");
 }
@@ -94,10 +91,10 @@ fn test_parcel_write_string_and_read_string() {
 #[test]
 fn test_parcel_reset_reader() {
     let mut parcel = Parcel::new();
-    parcel.write_i32(1);
-    parcel.write_i32(2);
+    let _ = parcel.write_i32(1);
+    let _ = parcel.write_i32(2);
     assert_eq!(parcel.read_i32().unwrap(), 1);
-    parcel.reset_reader();
+    let _ = parcel.reset_reader();
     assert_eq!(parcel.read_i32().unwrap(), 1);
     assert_eq!(parcel.read_i32().unwrap(), 2);
 }
@@ -105,8 +102,8 @@ fn test_parcel_reset_reader() {
 #[test]
 fn test_parcel_clear() {
     let mut parcel = Parcel::new();
-    parcel.write_i32(1);
-    parcel.clear();
+    let _ = parcel.write_i32(1);
+    let _ = parcel.clear();
     match parcel.read_i32() {
         Err(err) => {
             assert_eq!(err, ParcelError::NoData);
@@ -118,7 +115,7 @@ fn test_parcel_clear() {
 #[test]
 fn test_parcel_reset() {
     let mut parcel = Parcel::new();
-    parcel.reset(&[b'P']);
+    let _ = parcel.reset(&[b'P']);
     let res = parcel.read(1).unwrap();
     assert_eq!(res, [b'P']);
 }
@@ -126,8 +123,8 @@ fn test_parcel_reset() {
 #[test]
 fn test_parcel_get_raw_data() {
     let mut parcel = Parcel::new();
-    parcel.write_i32(1);
-    parcel.write_i32(2);
+    let _ = parcel.write_i32(1);
+    let _ = parcel.write_i32(2);
     let data = parcel.get_raw_data().unwrap();
     assert_ne!(data.len(), 0);
     assert_eq!(data, vec![1, 0, 0, 0, 2, 0, 0, 0]);