scsi: 3w-9xxx: Drop PCI Wakeup calls from .resume
authorVaibhav Gupta <vaibhavgupta40@gmail.com>
Mon, 2 Nov 2020 16:47:22 +0000 (22:17 +0530)
committerMartin K. Petersen <martin.petersen@oracle.com>
Thu, 26 Nov 2020 04:23:21 +0000 (23:23 -0500)
The driver calls pci_enable_wake(...., false) in twa_resume(), and there is
no corresponding pci_enable_wake(...., true) in twa_suspend().  Either it
should do enable-wake the device in .suspend() or should not invoke
pci_enable_wake() at all.

Concluding that this driver doesn't support enable-wake and PCI core calls
pci_enable_wake(pci_dev, PCI_D0, false) during resume, drop it from
twa_resume().

Link: https://lore.kernel.org/r/20201102164730.324035-22-vaibhavgupta40@gmail.com
Acked-by: Don Brace <don.brace@microchip.com>
Signed-off-by: Vaibhav Gupta <vaibhavgupta40@gmail.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/3w-9xxx.c

index 3337b1e..e458e99 100644 (file)
@@ -2230,7 +2230,6 @@ static int twa_resume(struct pci_dev *pdev)
 
        printk(KERN_WARNING "3w-9xxx: Resuming host %d.\n", tw_dev->host->host_no);
        pci_set_power_state(pdev, PCI_D0);
-       pci_enable_wake(pdev, PCI_D0, 0);
        pci_restore_state(pdev);
 
        retval = pci_enable_device(pdev);