git: Show all suggestions on pre-commit hook
authorColin Kinloch <colin.kinloch@collabora.com>
Thu, 1 Dec 2022 18:45:59 +0000 (18:45 +0000)
committerGStreamer Marge Bot <gitlab-merge-bot@gstreamer-foundation.org>
Fri, 2 Dec 2022 17:53:34 +0000 (17:53 +0000)
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/3506>

scripts/git-hooks/pre-commit.hook

index 1224ffd..3b9b5c3 100755 (executable)
@@ -68,18 +68,28 @@ for file in `git diff-index --cached --name-only HEAD --diff-filter=ACMR| grep "
     rm "${newfile}"
     rm "${nf}"
     if [ $r != 0 ] ; then
+        ERROR_FILES="$ERROR_FILES $file"
 echo "================================================================================================="
 echo " Code style error in: $file                                                                      "
+echo "================================================================================================="
+echo ""
+    fi
+done
+
+if [ -n "$ERROR_FILES" ];then
+echo "================================================================================================="
+echo " Code style error in:                                                                            "
+for file in $ERROR_FILES ; do
+echo "   $file"
+done
 echo "                                                                                                 "
 echo " Please fix before committing. Don't forget to run git add before trying to commit again.        "
 echo " If the whole file is to be committed, this should work (run from the top-level directory):      "
-echo "                                                                                                 "
-echo "   gst-indent $file; git add $file; git commit"
+echo "   scripts/gst-indent$ERROR_FILES ; git add$ERROR_FILES ; git commit"
 echo "                                                                                                 "
 echo "================================================================================================="
-        exit 1
-    fi
-done
+  exit 1
+fi
 
 csharp_files=` git diff-index --cached --name-only HEAD --diff-filter=ACMR| grep "^subprojects/gstreamer-sharp/.*cs$" `
 if test "x$csharp_files" != "x"; then