projects
/
platform
/
kernel
/
linux-starfive.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
ef018e1
)
spi: spi-rockchip: Fix missing unwind goto in rockchip_sfc_probe()
author
Li Lanzhe
<u202212060@hust.edu.cn>
Wed, 19 Apr 2023 11:50:29 +0000
(07:50 -0400)
committer
Greg Kroah-Hartman
<gregkh@linuxfoundation.org>
Wed, 26 Apr 2023 12:28:34 +0000
(14:28 +0200)
[ Upstream commit
359f5b0d4e26b7a7bcc574d6148b31a17cefe47d
]
If devm_request_irq() fails, then we are directly return 'ret' without
clk_disable_unprepare(sfc->clk) and clk_disable_unprepare(sfc->hclk).
Fix this by changing direct return to a goto 'err_irq'.
Fixes:
0b89fc0a367e
("spi: rockchip-sfc: add rockchip serial flash controller")
Signed-off-by: Li Lanzhe <u202212060@hust.edu.cn>
Reviewed-by: Dongliang Mu <dzm91@hust.edu.cn>
Link:
https://lore.kernel.org/r/20230419115030.6029-1-u202212060@hust.edu.cn
Signed-off-by: Mark Brown <broonie@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/spi/spi-rockchip-sfc.c
patch
|
blob
|
history
diff --git
a/drivers/spi/spi-rockchip-sfc.c
b/drivers/spi/spi-rockchip-sfc.c
index
bd87d3c
..
69347b6
100644
(file)
--- a/
drivers/spi/spi-rockchip-sfc.c
+++ b/
drivers/spi/spi-rockchip-sfc.c
@@
-632,7
+632,7
@@
static int rockchip_sfc_probe(struct platform_device *pdev)
if (ret) {
dev_err(dev, "Failed to request irq\n");
-
return ret
;
+
goto err_irq
;
}
ret = rockchip_sfc_init(sfc);