Fix defects detected by static analysis tool

Change-Id: I1c36170c38f070450b2470fd23f95df53c4136d0

diff --git a/src/multi_assistant_service.c b/src/multi_assistant_service.c
index 1c4eff0..c05726d 100644 (file)
--- a/src/multi_assistant_service.c
+++ b/src/multi_assistant_service.c
@@ -168,7 +168,7 @@ bool check_preprocessing_assistant_exists()
        char* vconf_str = vconf_get_str(WAKEUP_SETTINGS_KEY_PREPROCESSING_ASSISTANT_APPID);
        if (vconf_str) {
                for (int loop = 0; loop < MAX_MACLIENT_INFO_NUM; loop++) {
-                       if (g_maclient_info[loop].used && g_maclient_info[loop].appid) {
+                       if (g_maclient_info[loop].used) {
                                if (strncmp(vconf_str, g_maclient_info[loop].appid, MAX_APPID_LEN) == 0) {
                                        ret = true;
                                }
@@ -452,8 +452,8 @@ int mas_client_set_preprocessing_allow_mode(int pid, int mode, const char* appid
        }
 
        for (int loop = 0; loop < MAX_MACLIENT_INFO_NUM; loop++) {
-               if (g_maclient_info[loop].used && g_maclient_info[loop].appid) {
-                       if (strncmp(pid_appid, g_maclient_info[loop].appid, MAX_APPID_LEN) == 0) {
+               if (g_maclient_info[loop].used) {
+                       if (pid_appid && strncmp(pid_appid, g_maclient_info[loop].appid, MAX_APPID_LEN) == 0) {
                                g_maclient_info[loop].preprocessing_allow_mode = mode;
                                strncpy(g_maclient_info[loop].preprocessing_allow_appid, appid, MAX_APPID_LEN);
                                g_maclient_info[loop].preprocessing_allow_appid[MAX_APPID_LEN - 1] = '\0';
@@ -1018,7 +1018,7 @@ int mas_process_voice_key_event(bool pressed)
 ma_preprocessing_allow_mode_e get_preprocessing_allow_mode(const char* appid)
 {
        for (int loop = 0; loop < MAX_MACLIENT_INFO_NUM; loop++) {
-               if (g_maclient_info[loop].used && g_maclient_info[loop].appid) {
+               if (g_maclient_info[loop].used) {
                        if (strncmp(appid, g_maclient_info[loop].appid, MAX_APPID_LEN) == 0) {
                                return g_maclient_info[loop].preprocessing_allow_mode;
                        }