projects
/
platform
/
kernel
/
linux-rpi.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
afa7885
)
cxl/pci: Fix NULL vs ERR_PTR confusion
author
Dan Williams
<dan.j.williams@intel.com>
Fri, 15 Oct 2021 21:29:58 +0000
(14:29 -0700)
committer
Greg Kroah-Hartman
<gregkh@linuxfoundation.org>
Thu, 18 Nov 2021 18:16:04 +0000
(19:16 +0100)
commit
ca76a3a8052b71c0334d5c094859cfa340c290a8
upstream.
cxl_pci_map_regblock() may return an ERR_PTR(), but cxl_pci_setup_regs()
is only prepared for NULL as the error case. Pick the minimal fix for
-stable backport purposes and just have cxl_pci_map_regblock() return
NULL for errors.
Fixes:
f8a7e8c29be8
("cxl/pci: Reserve all device regions at once")
Cc: <stable@vger.kernel.org>
Reviewed-by: Ira Weiny <ira.weiny@intel.com>
Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Link:
https://lore.kernel.org/r/163433325724.834522.17809774578178224149.stgit@dwillia2-desk3.amr.corp.intel.com
Signed-off-by: Dan Williams <dan.j.williams@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/cxl/pci.c
patch
|
blob
|
history
diff --git
a/drivers/cxl/pci.c
b/drivers/cxl/pci.c
index
8e45aa0
..
5444b5a
100644
(file)
--- a/
drivers/cxl/pci.c
+++ b/
drivers/cxl/pci.c
@@
-972,7
+972,7
@@
static void __iomem *cxl_mem_map_regblock(struct cxl_mem *cxlm,
if (pci_resource_len(pdev, bar) < offset) {
dev_err(dev, "BAR%d: %pr: too small (offset: %#llx)\n", bar,
&pdev->resource[bar], (unsigned long long)offset);
- return
IOMEM_ERR_PTR(-ENXIO)
;
+ return
NULL
;
}
addr = pci_iomap(pdev, bar, 0);