dmaengine: tegra: Fix uninitialized variable usage
authorAkhil R <akhilrajeev@nvidia.com>
Tue, 26 Apr 2022 10:19:12 +0000 (15:49 +0530)
committerVinod Koul <vkoul@kernel.org>
Thu, 19 May 2022 18:13:41 +0000 (23:43 +0530)
Initialize slave_bw in dma_prep*() functions as the parameter is not
set for DMA_MEM_TO_MEM case in get_transfer_param(). Though the case
may never occur, initializing it avoids warning from certain static
checkers

Fixes: ee17028009d4 ("dmaengine: tegra: Add tegra gpcdma driver")
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Akhil R <akhilrajeev@nvidia.com>
Link: https://lore.kernel.org/r/20220426101913.43335-2-akhilrajeev@nvidia.com
Signed-off-by: Vinod Koul <vkoul@kernel.org>
drivers/dma/tegra186-gpc-dma.c

index 3951db5..b33c9b7 100644 (file)
@@ -984,8 +984,8 @@ tegra_dma_prep_slave_sg(struct dma_chan *dc, struct scatterlist *sgl,
 {
        struct tegra_dma_channel *tdc = to_tegra_dma_chan(dc);
        unsigned int max_dma_count = tdc->tdma->chip_data->max_dma_count;
+       enum dma_slave_buswidth slave_bw = DMA_SLAVE_BUSWIDTH_UNDEFINED;
        u32 csr, mc_seq, apb_ptr = 0, mmio_seq = 0;
-       enum dma_slave_buswidth slave_bw;
        struct tegra_dma_sg_req *sg_req;
        struct tegra_dma_desc *dma_desc;
        struct scatterlist *sg;
@@ -1102,12 +1102,12 @@ tegra_dma_prep_dma_cyclic(struct dma_chan *dc, dma_addr_t buf_addr, size_t buf_l
                          size_t period_len, enum dma_transfer_direction direction,
                          unsigned long flags)
 {
+       enum dma_slave_buswidth slave_bw = DMA_SLAVE_BUSWIDTH_UNDEFINED;
+       u32 csr, mc_seq, apb_ptr = 0, mmio_seq = 0, burst_size;
+       unsigned int max_dma_count, len, period_count, i;
        struct tegra_dma_channel *tdc = to_tegra_dma_chan(dc);
        struct tegra_dma_desc *dma_desc;
        struct tegra_dma_sg_req *sg_req;
-       enum dma_slave_buswidth slave_bw;
-       u32 csr, mc_seq, apb_ptr = 0, mmio_seq = 0, burst_size;
-       unsigned int max_dma_count, len, period_count, i;
        dma_addr_t mem = buf_addr;
        int ret;