HID: input: fix assignment of .value
authorBenjamin Tissoires <benjamin.tissoires@redhat.com>
Thu, 18 Apr 2019 07:47:41 +0000 (09:47 +0200)
committerBenjamin Tissoires <benjamin.tissoires@redhat.com>
Wed, 24 Apr 2019 13:25:29 +0000 (15:25 +0200)
The value field is actually an array of .maxfield. We should assign the
correct number to the correct usage.

Not that we never encounter a device that requires this ATM, but better
have the proper code path.

Fixes: 2dc702c991e377 ("HID: input: use the Resolution Multiplier for
       high-resolution scrolling")
Cc: stable@vger.kernel.org # v5.0+
Signed-off-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
drivers/hid/hid-input.c

index fadf76f..6dd0294 100644 (file)
@@ -1580,7 +1580,7 @@ static bool __hidinput_change_resolution_multipliers(struct hid_device *hid,
                        if (usage->hid != HID_GD_RESOLUTION_MULTIPLIER)
                                continue;
 
-                       *report->field[i]->value = value;
+                       report->field[i]->value[j] = value;
                        update_needed = true;
                }
        }