[VD][MM] Fix mute failure issue 01/323501/2
authorrabarquez <r.abarquez@samsung.com>
Tue, 29 Apr 2025 10:49:39 +0000 (10:49 +0000)
committerrabarquez <r.abarquez@samsung.com>
Tue, 29 Apr 2025 10:54:33 +0000 (10:54 +0000)
Issue: On suspend when new tab is opened, volume is set to default value 1.0
       Thus, audio is audible when video is resumed.

Fix: Retrieve current volume from renderer.
     On resume, set volume to current volume instead of the default value set on suspend

Reference: http://10.40.78.157/reviews/12812820/
Change-Id: I9ad47e76797edc38d3e9c09f719e3c0d3e2a07aa
Signed-off-by: rabarquez <r.abarquez@samsung.com>
tizen_src/chromium_impl/content/browser/media/tizen_renderer_impl.h
tizen_src/chromium_impl/media/filters/media_player_esplusplayer.cc
tizen_src/chromium_impl/media/filters/media_player_tizen_client.h

index 6c2ac2b0eff34751cf86fafd9652c5aaedf39d24..cf3e18309cbcb61414931f01e33b2353c7951a02 100644 (file)
@@ -130,6 +130,7 @@ class CONTENT_EXPORT TizenRendererImpl
   void OnVideoSizeChange(const gfx::Size& size) override;
   void OnDurationChange(base::TimeDelta duration) override;
   void OnBufferUpdate(base::TimeDelta time) override;
+  double GetCurrentVolume() override { return volume_; }
 
 #if BUILDFLAG(IS_TIZEN_TV)
   void NotifyTrackInfoToBrowser(int active_track_id) override;
index f05ca46c64db9b988acc0f9590399ae6e06a2137..60f06e846af9cbd09812b219cadc54f69d677dc7 100644 (file)
@@ -445,7 +445,7 @@ bool MediaPlayerESPlusPlayer::Play() {
     // return;
   }
 
-  SetVolume(volume_);
+  SetVolume(GetMediaPlayerClient()->GetCurrentVolume());
   if (should_set_playback_rate_) {
     LOG_ID(INFO, player_id_)
         << "set pending playback rate:" << pending_playback_rate_;
index 33ef80aad8a801cd006eb078c600a84b3b920ade..0d913ea301752f576bfc7e4e3a57cb43c4c6fc6d 100644 (file)
@@ -42,6 +42,7 @@ class MEDIA_EXPORT MediaPlayerTizenClient {
                                     bool is_live) = 0;
   virtual void OnRequestSeek(base::TimeDelta time) = 0;
   virtual void OnRequestSuspend(bool resource_conflict) = 0;
+  virtual double GetCurrentVolume() = 0;
 
 #if BUILDFLAG(IS_TIZEN_TV)
   virtual void NotifyTrackInfoToBrowser(int active_track_id) = 0;