media: dvb-frontends/stv0910: fix STR assignment, remove unneeded var
authorDaniel Scheller <d.scheller@gmx.net>
Sun, 23 Jul 2017 10:13:09 +0000 (06:13 -0400)
committerMauro Carvalho Chehab <mchehab@s-opensource.com>
Sun, 20 Aug 2017 11:11:06 +0000 (07:11 -0400)
According to the documentation, FE_SCALE_DECIBEL values should be assigned
to .svalue and not .uvalue, so let's do this. While at it, remove the
unneeded strength var from read_signal_strength().

Signed-off-by: Daniel Scheller <d.scheller@gmx.net>
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
drivers/media/dvb-frontends/stv0910.c

index 7e8a460..b596ec5 100644 (file)
@@ -1321,7 +1321,6 @@ static void read_signal_strength(struct dvb_frontend *fe)
 {
        struct stv *state = fe->demodulator_priv;
        struct dtv_frontend_properties *p = &state->fe.dtv_property_cache;
-       s64 strength;
        u8 reg[2];
        u16 agc;
        s32 padc, power = 0;
@@ -1341,10 +1340,8 @@ static void read_signal_strength(struct dvb_frontend *fe)
 
        padc = table_lookup(padc_lookup, ARRAY_SIZE(padc_lookup), power) + 352;
 
-       strength = (padc - agc);
-
        p->strength.stat[0].scale = FE_SCALE_DECIBEL;
-       p->strength.stat[0].uvalue = strength;
+       p->strength.stat[0].svalue = (padc - agc);
 }
 
 static int read_status(struct dvb_frontend *fe, enum fe_status *status)