staging: erofs: remove the redundant d_rehash() for the root dentry
authorGao Xiang <gaoxiang25@huawei.com>
Sat, 3 Nov 2018 09:23:56 +0000 (17:23 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 27 Feb 2019 09:09:02 +0000 (10:09 +0100)
commit e9c892465583c8f42d61fafe30970d36580925df upstream.

There is actually no need at all to d_rehash() for the root dentry
as Al pointed out, fix it.

Reported-by: Al Viro <viro@ZenIV.linux.org.uk>
Cc: Al Viro <viro@ZenIV.linux.org.uk>
Signed-off-by: Gao Xiang <gaoxiang25@huawei.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/erofs/super.c

index 2df9768..434616b 100644 (file)
@@ -404,12 +404,6 @@ static int erofs_read_super(struct super_block *sb,
 
        erofs_register_super(sb);
 
-       /*
-        * We already have a positive dentry, which was instantiated
-        * by d_make_root. Just need to d_rehash it.
-        */
-       d_rehash(sb->s_root);
-
        if (!silent)
                infoln("mounted on %s with opts: %s.", dev_name,
                        (char *)data);